Hide kernel isolate from isolate list; do not register it either

Hide kernel isolate from isolate list; do not register it either

This is basically a copy of https://codereview.chromium.org/2689563010/
and https://codereview.chromium.org/2695013002/ - just hiding the kernel
isolate too.
That way, we won't see it and be confused when debugging via observatory.
Also, service tests could probably start working with the kernel isolate
too.

Still show isolate if passing "--show_kernel_isolate" though.

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/137b85c114791bb2e8074083517a32f908156c29

[jensj, 2017-02-14 12:58:18]

jensj@google.com changed reviewers:
+ hausner@google.com, vegorov@google.com

[Vyacheslav Egorov (Google), 2017-02-14 13:02:26]

https://codereview.chromium.org/2690323003/diff/1/runtime/lib/vmservice.cc
File runtime/lib/vmservice.cc (right):

https://codereview.chromium.org/2690323003/diff/1/runtime/lib/vmservice.cc#ne...
runtime/lib/vmservice.cc:65: if (IsVMInternalIsolate(isolate) ||
is_kernel_isolate) {
Maybe this should just move this check into the IsVMInternalIsolate?

[Cutch, 2017-02-14 13:03:27]

On 2017/02/14 13:02:26, Vyacheslav Egorov (Google) wrote:
> https://codereview.chromium.org/2690323003/diff/1/runtime/lib/vmservice.cc
> File runtime/lib/vmservice.cc (right):
> 
>
https://codereview.chromium.org/2690323003/diff/1/runtime/lib/vmservice.cc#ne...
> runtime/lib/vmservice.cc:65: if (IsVMInternalIsolate(isolate) ||
> is_kernel_isolate) {
> Maybe this should just move this check into the IsVMInternalIsolate?

+1

[jensj, 2017-02-14 13:15:56]

That doesn't work. The process hangs on exit.

Probably because the class IsolateKillerVisitor, method ShouldKill (in
isolate.cc) will then skip it too.

[hausner, 2017-02-14 13:22:52]

Will this change prevent the Observatory from profiling the Kernel Isolate? I
think we should preserve profiling for the KI. We'll need it at least until we
are happy with performance.

[Cutch, 2017-02-14 13:43:29]

On 2017/02/14 13:22:52, hausner wrote:
> Will this change prevent the Observatory from profiling the Kernel Isolate? I
> think we should preserve profiling for the KI. We'll need it at least until we
> are happy with performance.

Yes, it would hide it from the profiler.

[hausner, 2017-02-14 13:55:57]

I think it's better to be able to see the Kernel isolate in the Observatory and
Profiler, so we can work on performance.

[jensj, 2017-02-21 11:48:11]

On 2017/02/14 13:55:57, hausner wrote:
> I think it's better to be able to see the Kernel isolate in the Observatory
and
> Profiler, so we can work on performance.

How about a flag then?

Generally I would suppose we don't want to see the kernel isolate.
For service tests we definitely don't want to see it.

If we specifically want to profile the kernel isolate, running it with a flag
doesn't seem too bad?

[jensj, 2017-03-06 09:53:40]

ping.

With the switch to fasta and all tests running through the service isolate, I
really feel like we need this.

[Vyacheslav Egorov (Google), 2017-03-06 17:34:59]

vegorov@google.com changed reviewers:
+ asiva@google.com, turnidge@google.com

[Vyacheslav Egorov (Google), 2017-03-06 17:34:59]

+turnidge +asiva 

per discussion on the meeting

[hausner, 2017-03-06 17:35:53]

LGTM if there is a flag to make the kernel isolate visible in the Observatory.

[Cutch, 2017-03-07 01:33:25]

On 2017/03/06 17:35:53, hausner wrote:
> LGTM if there is a flag to make the kernel isolate visible in the Observatory.

+1 to having a flag. Considering how important the performance of the kernel
isolate is we need an easy to profile it.

[jensj, 2017-03-07 07:26:45]

Description was changed from

==========
Hide kernel isolate from isolate list; do not register it either

This is basically a copy of https://codereview.chromium.org/2689563010/
and https://codereview.chromium.org/2695013002/ - just hiding the kernel
isolate too.
That way, we won't see it and be confused when debugging via observatory.
Also, service tests could probably start working with the kernel isolate
too.
==========

to

==========
Hide kernel isolate from isolate list; do not register it either

This is basically a copy of https://codereview.chromium.org/2689563010/
and https://codereview.chromium.org/2695013002/ - just hiding the kernel
isolate too.
That way, we won't see it and be confused when debugging via observatory.
Also, service tests could probably start working with the kernel isolate
too.

Still show isolate if passing "--show_kernel_isolate" though.
==========

[jensj, 2017-03-07 07:27:20]

Description was changed from

==========
Hide kernel isolate from isolate list; do not register it either

This is basically a copy of https://codereview.chromium.org/2689563010/
and https://codereview.chromium.org/2695013002/ - just hiding the kernel
isolate too.
That way, we won't see it and be confused when debugging via observatory.
Also, service tests could probably start working with the kernel isolate
too.

Still show isolate if passing "--show_kernel_isolate" though.
==========

to

==========
Hide kernel isolate from isolate list; do not register it either

This is basically a copy of https://codereview.chromium.org/2689563010/
and https://codereview.chromium.org/2695013002/ - just hiding the kernel
isolate too.
That way, we won't see it and be confused when debugging via observatory.
Also, service tests could probably start working with the kernel isolate
too.

Still show isolate if passing "--show_kernel_isolate" though.

R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/137b85c114791bb2e8074083517a32f908156c29
==========

[jensj, 2017-03-07 07:27:22]

Committed patchset #2 (id:20001) manually as
137b85c114791bb2e8074083517a32f908156c29 (presubmit successful).