Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2690303009: Remove a few unnecssary scopers from unit tests. (Closed)

Created:
3 years, 10 months ago by dcheng
Modified:
3 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove a few unnecssary scopers from unit tests. TestWithIsolate and TestWithContext already instantiate the scopers. BUG=none Review-Url: https://codereview.chromium.org/2690303009 Cr-Commit-Position: refs/heads/master@{#43268} Committed: https://chromium.googlesource.com/v8/v8/+/c5ccae970d2da991a18f7a3aed116e72e98b432d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M test/unittests/api/isolate-unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M test/unittests/api/v8-object-unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dcheng
Random cleanup I noticed while writing some new tests.
3 years, 10 months ago (2017-02-16 10:59:09 UTC) #4
Toon Verwaest
lgtm
3 years, 10 months ago (2017-02-17 09:23:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690303009/1
3 years, 10 months ago (2017-02-17 09:49:30 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 09:51:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c5ccae970d2da991a18f7a3aed116e72e98...

Powered by Google App Engine
This is Rietveld 408576698