Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2690293002: [Devtools] Redirect initiators link to redirected network request (Closed)

Created:
3 years, 10 months ago by allada
Modified:
3 years, 10 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Redirect initiators link to redirected network request This patch changes the logic used for initiators. When a request is found in the network log it will change the linking to reveal and highlight in the network panel instead of moving to resource/application panel. R=lushnikov BUG=533746, 691790 Review-Url: https://codereview.chromium.org/2690293002 Cr-Commit-Position: refs/heads/master@{#450916} Committed: https://chromium.googlesource.com/chromium/src/+/3f9be266524354849e17f6a123ee20dd6e7d53e0

Patch Set 1 : [Devtools] Redirect initiators link to redirected network request #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 22 (14 generated)
allada
PTL
3 years, 10 months ago (2017-02-13 23:12:29 UTC) #2
lushnikov
lgtm
3 years, 10 months ago (2017-02-15 21:45:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690293002/20001
3 years, 10 months ago (2017-02-15 21:46:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-16 02:22:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690293002/20001
3 years, 10 months ago (2017-02-16 03:06:21 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/391374)
3 years, 10 months ago (2017-02-16 07:03:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690293002/20001
3 years, 10 months ago (2017-02-16 08:18:04 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 09:36:11 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3f9be266524354849e17f6a123ee...

Powered by Google App Engine
This is Rietveld 408576698