Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2690213002: PPC/s390: [turbofan] Correct lazy deopt by {JSCreate} operation. (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [turbofan] Correct lazy deopt by {JSCreate} operation. Port 6ee0b6cec6b83791af8d3a7e122f14e4eb376974 Original Commit Message: This adds support for deoptimizing into the JSConstructStub after the receiver instantiation but before the actual constructor invocation. Such a deoptimization point is needed for cases where instantiation might be observed (e.g. when new.target is a proxy) and hence might trigger a deopt. We use this new deoptimization point for the "after" frame-state the inliner attaches to {JSCreate} nodes being inserted when constructor calls are being inlined. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5638 LOG=N Review-Url: https://codereview.chromium.org/2690213002 Cr-Commit-Position: refs/heads/master@{#43171} Committed: https://chromium.googlesource.com/v8/v8/+/2703b06e6f3e6a1bab4ab5c5e90034472d02423d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -2 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 4 chunks +34 lines, -1 line 0 comments Download
M src/builtins/s390/builtins-s390.cc View 4 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-02-13 21:31:02 UTC) #1
john.yan
lgtm
3 years, 10 months ago (2017-02-13 22:18:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690213002/1
3 years, 10 months ago (2017-02-13 22:18:32 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 22:42:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2703b06e6f3e6a1bab4ab5c5e90034472d0...

Powered by Google App Engine
This is Rietveld 408576698