Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2690203002: Add support for additional libraries to FE API (Closed)

Created:
3 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for additional libraries to FE API (this was already reviewd on another CL, I'm just pulling it aside) BUG= R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/45b7a8334c0afe7f19b262a773d0c62a11c307d2

Patch Set 1 #

Total comments: 4

Patch Set 2 : add support for additional libraries to FE API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M pkg/front_end/lib/compiler_options.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/kernel_generator.dart View 1 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-02-13 21:13:58 UTC) #2
Paul Berry
https://codereview.chromium.org/2690203002/diff/1/pkg/front_end/lib/kernel_generator.dart File pkg/front_end/lib/kernel_generator.dart (right): https://codereview.chromium.org/2690203002/diff/1/pkg/front_end/lib/kernel_generator.dart#newcode43 pkg/front_end/lib/kernel_generator.dart:43: options.additionalLibraries.forEach((e) { print('$e'); Is this temporary debugging code? Can ...
3 years, 10 months ago (2017-02-13 21:17:43 UTC) #3
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2690203002/diff/1/pkg/front_end/lib/kernel_generator.dart File pkg/front_end/lib/kernel_generator.dart (right): https://codereview.chromium.org/2690203002/diff/1/pkg/front_end/lib/kernel_generator.dart#newcode43 pkg/front_end/lib/kernel_generator.dart:43: options.additionalLibraries.forEach((e) { print('$e'); On 2017/02/13 21:17:42, Paul Berry wrote: ...
3 years, 10 months ago (2017-02-13 21:23:11 UTC) #4
Paul Berry
lgtm
3 years, 10 months ago (2017-02-13 21:23:57 UTC) #5
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-02-13 21:28:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
45b7a8334c0afe7f19b262a773d0c62a11c307d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698