Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: pkg/front_end/lib/kernel_generator.dart

Issue 2690203002: Add support for additional libraries to FE API (Closed)
Patch Set: add support for additional libraries to FE API Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/compiler_options.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/kernel_generator.dart
diff --git a/pkg/front_end/lib/kernel_generator.dart b/pkg/front_end/lib/kernel_generator.dart
index 086f45adea80856cf9d65959acb630cde6db9b6b..b76b54a1b1f4f807789598c28c3b60d1de7ffc47 100644
--- a/pkg/front_end/lib/kernel_generator.dart
+++ b/pkg/front_end/lib/kernel_generator.dart
@@ -38,17 +38,11 @@ import 'package:source_span/source_span.dart' show SourceSpan;
/// needed to access the contents of method bodies).
Future<Program> kernelForProgram(Uri source, CompilerOptions options) async {
var loader = await _createLoader(options, entry: source);
- // TODO(sigmund): delete this. At this time we have no need to explicitly list
- // VM libraries, since they are normally found by chasing dependencies.
- // `dart:_builtin` is an exception because it is used by the kernel
- // transformers to inform the VM about where the main entrypoint is. This is
- // expected to change, and we should be able to remove these lines at that
- // point. We check for the presense of `dart:developer` in the targetPatches
- // to ensure we only load this library while running on the VM.
- if (options.compileSdk &&
- options.targetPatches.containsKey(Uri.parse('dart:developer'))) {
- loader.loadLibrary(Uri.parse('dart:_builtin'));
+
+ if (options.compileSdk) {
+ options.additionalLibraries.forEach(loader.loadLibrary);
}
+
// TODO(sigmund): merge what we have in loadEverything and the logic below in
// kernelForBuildUnit so there is a single place where we crawl for
// dependencies.
« no previous file with comments | « pkg/front_end/lib/compiler_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698