Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
Review-Url: https://codereview.chromium.org/2690183006
Cr-Commit-Position: refs/heads/master@{#452086}
Committed: https://chromium.googlesource.com/chromium/src/+/c97f87f582759e60200bc91677dfba13f87114ff

[zakerinasab, 2017-02-15 16:33:56]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

[zakerinasab, 2017-02-15 16:33:56]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2017-02-21 22:03:13]

lgtm with nit

https://codereview.chromium.org/2690183006/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-strokeRect.html (right):

https://codereview.chromium.org/2690183006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-strokeRect.html:13:
assert_array_equals(ctx.getImageData(2, 1, 1, 1).data.slice(0,3), [0, 128, 0]);
I see 5 individual tests here. Could you break this up into 5 calls to test()?

[zakerinasab, 2017-02-22 15:42:44]

Comment addressed.

https://codereview.chromium.org/2690183006/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-strokeRect.html (right):

https://codereview.chromium.org/2690183006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-strokeRect.html:13:
assert_array_equals(ctx.getImageData(2, 1, 1, 1).data.slice(0,3), [0, 128, 0]);
On 2017/02/21 22:03:13, Justin Novosad wrote:
> I see 5 individual tests here. Could you break this up into 5 calls to test()?

Done.

[zakerinasab, 2017-02-22 15:42:59]

The CQ bit was checked by zakerinasab@chromium.org

[zakerinasab, 2017-02-22 15:42:59]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2690183006/#ps40001
(title: "Addressing comments")

[commit-bot: I haz the power, 2017-02-22 15:43:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 16:48:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487778179045350,
"parent_rev": "7348f0095cf19f8747e5e0dbdad4d91bc0fff0eb", "commit_rev":
"c97f87f582759e60200bc91677dfba13f87114ff"}

[commit-bot: I haz the power, 2017-02-22 16:48:39]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2690183006
Cr-Commit-Position: refs/heads/master@{#452086}
Committed:
https://chromium.googlesource.com/chromium/src/+/c97f87f582759e60200bc91677df...
==========

[commit-bot: I haz the power, 2017-02-22 16:48:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c97f87f582759e60200bc91677df...