|
|
DescriptionChange platform methods and try to make init logging logic clearer
BUG=686608
Review-Url: https://codereview.chromium.org/2690163005
Cr-Commit-Position: refs/heads/master@{#451229}
Committed: https://chromium.googlesource.com/chromium/src/+/836c34d725d9bc2bd5e071fd0ff99ac0330bca68
Patch Set 1 #Patch Set 2 : fixed compilation error #Patch Set 3 : Updated upstream, removed unused variable (does not compile in Windows) #Patch Set 4 : Updated upstream #Patch Set 5 : Uploaded upstream #
Messages
Total messages: 35 (22 generated)
The CQ bit was checked by dvallet@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== format Changed platform methods and try to make init logging logic clearer BUG=686608 ========== to ========== BUG=686608 ==========
dvallet@chromium.org changed reviewers: + skyostil@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm. Please copy the title to the first line of the patch description too since that's what ends up in the repository.
Description was changed from ========== BUG=686608 ========== to ========== Change platform methods and try to make init logging logic clearer BUG=686608 ==========
The CQ bit was checked by dvallet@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dvallet@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/2690163005/#ps40001 (title: "Updated upstream, removed unused variable (does not compile in Windows)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by dvallet@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by dvallet@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/2690163005/#ps60001 (title: "Updated upstream")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dvallet@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/2690163005/#ps80001 (title: "Uploaded upstream")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by dvallet@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487300685806610, "parent_rev": "b94da02e9f37dce40a55fd4a88f60269d10a749d", "commit_rev": "836c34d725d9bc2bd5e071fd0ff99ac0330bca68"}
Message was sent while issue was closed.
Description was changed from ========== Change platform methods and try to make init logging logic clearer BUG=686608 ========== to ========== Change platform methods and try to make init logging logic clearer BUG=686608 Review-Url: https://codereview.chromium.org/2690163005 Cr-Commit-Position: refs/heads/master@{#451229} Committed: https://chromium.googlesource.com/chromium/src/+/836c34d725d9bc2bd5e071fd0ff9... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/836c34d725d9bc2bd5e071fd0ff9... |