Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2690163005: Change platform methods and try to make init logging logic clearer (Closed)

Created:
3 years, 10 months ago by dvallet
Modified:
3 years, 10 months ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change platform methods and try to make init logging logic clearer BUG=686608 Review-Url: https://codereview.chromium.org/2690163005 Cr-Commit-Position: refs/heads/master@{#451229} Committed: https://chromium.googlesource.com/chromium/src/+/836c34d725d9bc2bd5e071fd0ff99ac0330bca68

Patch Set 1 #

Patch Set 2 : fixed compilation error #

Patch Set 3 : Updated upstream, removed unused variable (does not compile in Windows) #

Patch Set 4 : Updated upstream #

Patch Set 5 : Uploaded upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M headless/lib/browser/headless_browser_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_browser_impl_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M headless/lib/browser/headless_web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M headless/lib/headless_content_main_delegate.cc View 1 2 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 35 (22 generated)
dvallet
3 years, 10 months ago (2017-02-15 06:46:34 UTC) #5
Sami
lgtm. Please copy the title to the first line of the patch description too since ...
3 years, 10 months ago (2017-02-15 11:11:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690163005/20001
3 years, 10 months ago (2017-02-15 21:48:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690163005/40001
3 years, 10 months ago (2017-02-15 22:49:51 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on ...
3 years, 10 months ago (2017-02-16 00:53:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690163005/40001
3 years, 10 months ago (2017-02-16 00:58:09 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-16 03:00:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690163005/60001
3 years, 10 months ago (2017-02-16 06:06:25 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/391586)
3 years, 10 months ago (2017-02-16 08:47:35 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690163005/80001
3 years, 10 months ago (2017-02-17 00:34:38 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on ...
3 years, 10 months ago (2017-02-17 02:39:36 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690163005/80001
3 years, 10 months ago (2017-02-17 03:05:43 UTC) #32
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 05:18:08 UTC) #35
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/836c34d725d9bc2bd5e071fd0ff9...

Powered by Google App Engine
This is Rietveld 408576698