Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2690163004: [tests] make the function expression an iife to run the test (Closed)

Created:
3 years, 10 months ago by gsathya
Modified:
3 years, 10 months ago
Reviewers:
neis, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tests] make the function expression, an iife to run the test R=neis@chromium.org Review-Url: https://codereview.chromium.org/2690163004 Cr-Commit-Position: refs/heads/master@{#43180} Committed: https://chromium.googlesource.com/v8/v8/+/a09157033b872215fbd534f8e31f704eb777c228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/es6/promises.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
gsathya
3 years, 10 months ago (2017-02-14 09:53:57 UTC) #5
neis
lgtm
3 years, 10 months ago (2017-02-14 09:57:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690163004/1
3 years, 10 months ago (2017-02-14 09:57:30 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 10:15:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a09157033b872215fbd534f8e31f704eb77...

Powered by Google App Engine
This is Rietveld 408576698