Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2690163003: Rename CRIWVWebView to CWVWebView. (Closed)

Created:
3 years, 10 months ago by michaeldo
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename CRIWVWebView to CWVWebView. BUG=690807 Review-Url: https://codereview.chromium.org/2690163003 Cr-Commit-Position: refs/heads/master@{#450217} Committed: https://chromium.googlesource.com/chromium/src/+/863710fd9ac3bf3a93cf7a311a4dab3222cfa44d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -284 lines) Patch
M ios/web_view/internal/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/internal/criwv.mm View 2 chunks +3 lines, -3 lines 0 comments Download
D ios/web_view/internal/criwv_web_view.mm View 1 chunk +0 lines, -188 lines 0 comments Download
A + ios/web_view/internal/cwv_web_view.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/web_view/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/public/criwv.h View 2 chunks +2 lines, -2 lines 0 comments Download
D ios/web_view/public/criwv_web_view.h View 1 chunk +0 lines, -74 lines 0 comments Download
M ios/web_view/public/criwv_web_view_configuration.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/public/criwv_web_view_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/web_view/public/cwv_web_view.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ios/web_view/shell/shell_view_controller.m View 4 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
michaeldo
3 years, 10 months ago (2017-02-13 23:49:45 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 10 months ago (2017-02-14 01:19:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690163003/1
3 years, 10 months ago (2017-02-14 01:20:23 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 03:14:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/863710fd9ac3bf3a93cf7a311a4d...

Powered by Google App Engine
This is Rietveld 408576698