Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2690123003: Add neis to ast/OWNERS and parsing/OWNERS (Closed)

Created:
3 years, 10 months ago by adamk
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, neis
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add neis to ast/OWNERS and parsing/OWNERS R=littledan@chromium.org, marja@chromium.org, vogelheim@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2690123003 Cr-Commit-Position: refs/heads/master@{#43196} Committed: https://chromium.googlesource.com/v8/v8/+/8ec17c7bb5ee10809f42dc8b07b1cdc2c54ad91e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/ast/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
adamk
Hi fellow parsing owners, I think Georg ought to be in these files too. He's ...
3 years, 10 months ago (2017-02-14 00:55:07 UTC) #2
marja
lgtm
3 years, 10 months ago (2017-02-14 09:32:24 UTC) #3
vogelheim
lgtm (src/parsing)
3 years, 10 months ago (2017-02-14 12:59:53 UTC) #4
Dan Ehrenberg
lgtm
3 years, 10 months ago (2017-02-14 13:35:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690123003/1
3 years, 10 months ago (2017-02-14 16:52:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690123003/1
3 years, 10 months ago (2017-02-14 16:53:24 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 16:54:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8ec17c7bb5ee10809f42dc8b07b1cdc2c54...

Powered by Google App Engine
This is Rietveld 408576698