Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 2690123002: 📰 Remove whitespace between card title and attribution (Closed)
Patch Set: cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/new_tab_page_snippets_card.xml
diff --git a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
index 650429e5e2020358196fee959ea4ed70fe629a73..e12be7efa796bb961990591d662e06c9912d23c3 100644
--- a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
+++ b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
@@ -20,6 +20,7 @@
android:layout_height="wrap_content"
android:layout_alignParentStart="true"
android:layout_toStartOf="@+id/article_thumbnail"
+ android:maxLines="2"
android:ellipsize="end"
android:textSize="16sp"
android:textColor="@color/snippets_headline_text_color"
@@ -90,7 +91,7 @@
android:layout_height="@dimen/snippets_thumbnail_size"
android:layout_alignParentTop="true"
android:layout_alignParentEnd="true"
- android:layout_marginStart="16dp"
+ android:layout_marginStart="@dimen/snippets_thumbnail_padding"
Michael van Ouwerkerk 2017/02/15 17:59:33 nit: should the dimension be renamed to "snippets_
dgn 2017/02/15 18:15:56 Done.
android:scaleType="centerCrop"
android:contentDescription="@null"
android:src="@null" />
« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698