Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <RelativeLayout | 6 <RelativeLayout |
| 7 xmlns:android="http://schemas.android.com/apk/res/android" | 7 xmlns:android="http://schemas.android.com/apk/res/android" |
| 8 xmlns:chrome="http://schemas.android.com/apk/res-auto" | 8 xmlns:chrome="http://schemas.android.com/apk/res-auto" |
| 9 xmlns:tools="http://schemas.android.com/tools" | 9 xmlns:tools="http://schemas.android.com/tools" |
| 10 android:id="@+id/snippets_card_view" | 10 android:id="@+id/snippets_card_view" |
| 11 android:layout_width="match_parent" | 11 android:layout_width="match_parent" |
| 12 android:layout_height="wrap_content" | 12 android:layout_height="wrap_content" |
| 13 android:foreground="@drawable/button_borderless_compat" | 13 android:foreground="@drawable/button_borderless_compat" |
| 14 android:padding="@dimen/snippets_padding" | 14 android:padding="@dimen/snippets_padding" |
| 15 android:background="@drawable/card_single"> | 15 android:background="@drawable/card_single"> |
| 16 | 16 |
| 17 <org.chromium.ui.widget.TextViewWithLeading | 17 <org.chromium.ui.widget.TextViewWithLeading |
| 18 android:id="@+id/article_headline" | 18 android:id="@+id/article_headline" |
| 19 android:layout_width="match_parent" | 19 android:layout_width="match_parent" |
| 20 android:layout_height="wrap_content" | 20 android:layout_height="wrap_content" |
| 21 android:layout_alignParentStart="true" | 21 android:layout_alignParentStart="true" |
| 22 android:layout_toStartOf="@+id/article_thumbnail" | 22 android:layout_toStartOf="@+id/article_thumbnail" |
| 23 android:maxLines="2" | |
| 23 android:ellipsize="end" | 24 android:ellipsize="end" |
| 24 android:textSize="16sp" | 25 android:textSize="16sp" |
| 25 android:textColor="@color/snippets_headline_text_color" | 26 android:textColor="@color/snippets_headline_text_color" |
| 26 chrome:leading="24dp" /> | 27 chrome:leading="24dp" /> |
| 27 | 28 |
| 28 <org.chromium.ui.widget.TextViewWithLeading | 29 <org.chromium.ui.widget.TextViewWithLeading |
| 29 android:id="@+id/article_snippet" | 30 android:id="@+id/article_snippet" |
| 30 android:layout_width="match_parent" | 31 android:layout_width="match_parent" |
| 31 android:layout_height="wrap_content" | 32 android:layout_height="wrap_content" |
| 32 android:layout_alignParentStart="true" | 33 android:layout_alignParentStart="true" |
| (...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 83 chrome:tint="#000" /> | 84 chrome:tint="#000" /> |
| 84 | 85 |
| 85 </LinearLayout> | 86 </LinearLayout> |
| 86 | 87 |
| 87 <ImageView | 88 <ImageView |
| 88 android:id="@+id/article_thumbnail" | 89 android:id="@+id/article_thumbnail" |
| 89 android:layout_width="@dimen/snippets_thumbnail_size" | 90 android:layout_width="@dimen/snippets_thumbnail_size" |
| 90 android:layout_height="@dimen/snippets_thumbnail_size" | 91 android:layout_height="@dimen/snippets_thumbnail_size" |
| 91 android:layout_alignParentTop="true" | 92 android:layout_alignParentTop="true" |
| 92 android:layout_alignParentEnd="true" | 93 android:layout_alignParentEnd="true" |
| 93 android:layout_marginStart="16dp" | 94 android:layout_marginStart="@dimen/snippets_thumbnail_padding" |
|
Michael van Ouwerkerk
2017/02/15 17:59:33
nit: should the dimension be renamed to "snippets_
dgn
2017/02/15 18:15:56
Done.
| |
| 94 android:scaleType="centerCrop" | 95 android:scaleType="centerCrop" |
| 95 android:contentDescription="@null" | 96 android:contentDescription="@null" |
| 96 android:src="@null" /> | 97 android:src="@null" /> |
| 97 </RelativeLayout> | 98 </RelativeLayout> |
| OLD | NEW |