Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2690083002: Add MultiSourceInformationStrategy (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add MultiSourceInformationStrategy - generate sourcemap for both engines using --use-multi-source-info R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/c94162a20f429a4364608000703f8f7530c111d3

Patch Set 1 #

Patch Set 2 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+680 lines, -140 lines) Patch
M pkg/compiler/lib/src/commandline_options.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/io/code_output.dart View 4 chunks +66 lines, -25 lines 0 comments Download
A pkg/compiler/lib/src/io/multi_information.dart View 1 1 chunk +290 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 11 chunks +51 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/io/source_map_builder.dart View 1 4 chunks +58 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 1 5 chunks +22 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js/js.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js/js_source_mapping.dart View 1 3 chunks +33 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +30 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 4 chunks +11 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 3 chunks +11 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/options.dart View 7 chunks +10 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/output_collector.dart View 1 chunk +10 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/output_type_test.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/source_mapping_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/sourcemaps/js_tracer.dart View 3 chunks +7 lines, -1 line 0 comments Download
A tests/compiler/dart2js/sourcemaps/multi_source_info_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart View 4 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-13 13:50:56 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-14 23:28:13 UTC) #3
Johnni Winther
3 years, 10 months ago (2017-02-20 10:36:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c94162a20f429a4364608000703f8f7530c111d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698