Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2690083002: Add MultiSourceInformationStrategy (Closed)
Patch Set: Cleanup. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 9c635a2eb4097554259008034fb50d508e5d5bf7..87221606cbfbda034ebbfc57ba0d0dfbab9e6757 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -30,6 +30,7 @@ import '../elements/resolution_types.dart';
import '../elements/types.dart';
import '../enqueue.dart'
show Enqueuer, EnqueueTask, ResolutionEnqueuer, TreeShakingEnqueuerStrategy;
+import '../io/multi_information.dart' show MultiSourceInformationStrategy;
import '../io/position_information.dart' show PositionSourceInformationStrategy;
import '../io/source_information.dart' show SourceInformationStrategy;
import '../io/start_end_information.dart'
@@ -520,19 +521,43 @@ class JavaScriptBackend extends Target {
Tracer tracer;
+ static SourceInformationStrategy createSourceInformationStrategy(
+ {bool generateSourceMap: false,
+ bool useMultiSourceInfo: false,
+ bool useNewSourceInfo: false}) {
+ if (!generateSourceMap) return const JavaScriptSourceInformationStrategy();
+ if (useMultiSourceInfo) {
+ if (useNewSourceInfo) {
+ return const MultiSourceInformationStrategy(const [
+ const PositionSourceInformationStrategy(),
+ const StartEndSourceInformationStrategy()
+ ]);
+ } else {
+ return const MultiSourceInformationStrategy(const [
+ const StartEndSourceInformationStrategy(),
+ const PositionSourceInformationStrategy()
+ ]);
+ }
+ } else if (useNewSourceInfo) {
+ return const PositionSourceInformationStrategy();
+ } else {
+ return const StartEndSourceInformationStrategy();
+ }
+ }
+
JavaScriptBackend(Compiler compiler,
{bool generateSourceMap: true,
bool useStartupEmitter: false,
+ bool useMultiSourceInfo: false,
bool useNewSourceInfo: false,
bool useKernel: false})
: rti = new _RuntimeTypes(compiler),
rtiEncoder = new _RuntimeTypesEncoder(compiler),
annotations = new Annotations(compiler),
- this.sourceInformationStrategy = generateSourceMap
- ? (useNewSourceInfo
- ? new PositionSourceInformationStrategy()
- : const StartEndSourceInformationStrategy())
- : const JavaScriptSourceInformationStrategy(),
+ this.sourceInformationStrategy = createSourceInformationStrategy(
+ generateSourceMap: generateSourceMap,
+ useMultiSourceInfo: useMultiSourceInfo,
+ useNewSourceInfo: useNewSourceInfo),
impacts = new BackendImpacts(compiler),
frontend = new JSFrontendAccess(compiler),
this.compiler = compiler {
« no previous file with comments | « pkg/compiler/lib/src/js/js_source_mapping.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698