Refactor CompilerOutput

Refactor CompilerOutput

- replace EventSink by OutputSink
- add OutputType instead of uses magic values in [extension].

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/0f25d7da946a2f8509aef3e13046ae3c44a0f5bd

[Johnni Winther, 2017-02-13 13:19:01]

Description was changed from

==========
Refactor CompilerOutput
==========

to

==========
Refactor CompilerOutput

- replace EventSink by OutputSink
- add OutputType instead of uses magic values in [extension].
==========

[Johnni Winther, 2017-02-13 13:19:11]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-02-14 23:14:17]

lgtm

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/compil...
File pkg/compiler/lib/compiler_new.dart (right):

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:45: part,
nit: rename to jsPart or jsChunk?

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:48: js_map,
nit: jsMap (maybe sourceMap is better?)

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:51: serialization_data,
serializationData

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/src/ol...
File pkg/compiler/lib/src/old_to_new_api.dart (right):

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/src/ol...
pkg/compiler/lib/src/old_to_new_api.dart:55: extension = 'deferred_map';
seems odd to inject that here, can you comment why we need that? What if we had
separate .dumpInfo and .deferredMap output types?

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/src/so...
File pkg/compiler/lib/src/source_file_provider.dart (right):

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/src/so...
pkg/compiler/lib/src/source_file_provider.dart:266: if (name == '') {
any reason not to handle the name != '' case separately like you had before?

[Johnni Winther, 2017-02-20 09:18:12]

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/compil...
File pkg/compiler/lib/compiler_new.dart (right):

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:45: part,
On 2017/02/14 23:14:17, Siggi Cherem (dart-lang) wrote:
> nit: rename to jsPart or jsChunk?

Done.

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:48: js_map,
On 2017/02/14 23:14:17, Siggi Cherem (dart-lang) wrote:
> nit: jsMap (maybe sourceMap is better?)

Done.

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/compil...
pkg/compiler/lib/compiler_new.dart:51: serialization_data,
On 2017/02/14 23:14:17, Siggi Cherem (dart-lang) wrote:
> serializationData

Done.

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/src/ol...
File pkg/compiler/lib/src/old_to_new_api.dart (right):

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/src/ol...
pkg/compiler/lib/src/old_to_new_api.dart:55: extension = 'deferred_map';
On 2017/02/14 23:14:17, Siggi Cherem (dart-lang) wrote:
> seems odd to inject that here, can you comment why we need that? What if we
had
> separate .dumpInfo and .deferredMap output types?

Pub uses '$name.$extension' as output name, so this just to ensure the same
behavior.

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/src/so...
File pkg/compiler/lib/src/source_file_provider.dart (right):

https://codereview.chromium.org/2690063002/diff/20001/pkg/compiler/lib/src/so...
pkg/compiler/lib/src/source_file_provider.dart:266: if (name == '') {
On 2017/02/14 23:14:17, Siggi Cherem (dart-lang) wrote:
> any reason not to handle the name != '' case separately like you had before?

Because we shouldn't really be putting semantics here. This is a step towards
that, but I need to change Pub as well.

[Johnni Winther, 2017-02-20 09:34:26]

Description was changed from

==========
Refactor CompilerOutput

- replace EventSink by OutputSink
- add OutputType instead of uses magic values in [extension].
==========

to

==========
Refactor CompilerOutput

- replace EventSink by OutputSink
- add OutputType instead of uses magic values in [extension].

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0f25d7da946a2f8509aef3e13046ae3c44a0f5bd
==========

[Johnni Winther, 2017-02-20 09:34:27]

Committed patchset #3 (id:40001) manually as
0f25d7da946a2f8509aef3e13046ae3c44a0f5bd (presubmit successful).