Refactor CompilerOutput

pkg/compiler/lib/src/old_to_new_api.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Implementation of the new compiler API in '../compiler_new.dart' through the
 /// old compiler API in '../compiler.dart'.
 
 library compiler.api.legacy;
 
 import 'dart:async' show EventSink, Future;
@@ skipping 22 matching lines @@
 
   @override
   void report(
       var code, Uri uri, int begin, int end, String message, Diagnostic kind) {
     _handler(uri, begin, end, message, kind);
   }
 }
 
 /// Implementation of [CompilerOutput] using an optional
 /// [CompilerOutputProvider].
+// TODO(johnniwinther): Change Pub to use the new interface and remove this.
 class LegacyCompilerOutput implements CompilerOutput {
   final CompilerOutputProvider _outputProvider;
 
   LegacyCompilerOutput([this._outputProvider]);
 
   @override
-  EventSink<String> createEventSink(String name, String extension) {
-    if (_outputProvider != null) return _outputProvider(name, extension);
-    return NullSink.outputProvider(name, extension);
+  OutputSink createOutputSink(String name, String extension, OutputType type) {
+    if (_outputProvider != null) {
+      switch (type) {
+        case OutputType.info:
+          if (extension == '') {
+            extension = 'deferred_map';

[Siggi Cherem (dart-lang), 2017/02/14 23:14:17]

seems odd to inject that here, can you comment why we need that? What if we had
separate .dumpInfo and .deferredMap output types?

[Johnni Winther, 2017/02/20 09:18:11]

Pub uses '$name.$extension' as output name, so this just to ensure the same
behavior.

+          }
+          break;
+        default:
+      }
+      return new LegacyOutputSink(_outputProvider(name, extension));
+    }
+    return NullSink.outputProvider(name, extension, type);
   }
 }
+
+class LegacyOutputSink implements OutputSink {
+  final EventSink<String> sink;
+
+  LegacyOutputSink(this.sink);
+
+  @override
+  void add(String event) => sink.add(event);
+
+  @override
+  void close() => sink.close();
+}