Revert of Stop MenuItemView From Directly Caching MenuController

Revert of Stop MenuItemView From Directly Caching MenuController (patchset #1 id:1 of https://codereview.chromium.org/2684993009/ )

Reason for revert:
Significant memory leak caught by ChromeOS ASan/LSan in the test added by this CL.

For details, please see:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/19518/steps/views_unittests/logs/MenuControllerTest.HostReceivesInputBeforeDestruction

Original issue's description:
> Stop MenuItemView From Directly Caching MenuController
> 
> When a MenuController closes its associated Widget is destroyed later on the
> MessageLoop. Due to this it is possible for a MenuHostRootView to receive input
> while the associated MenuController has been destroyed.
> 
> MenuHostRootView accesses the MenuController through MenuItemView which simply
> caches it. This change updates MenuItemView to take a WeakPtr to the controller.
> 
> TEST=MenuControllerTest.HostReceivesInputBeforeDestruction
> BUG=690097
> 
> Review-Url: https://codereview.chromium.org/2684993009
> Cr-Commit-Position: refs/heads/master@{#449663}
> Committed: https://chromium.googlesource.com/chromium/src/+/549b48a07f5ac2def1b8ad0549f3fddaf67b7ff5

TBR=sky@chromium.org,jonross@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=690097
Review-Url: https://codereview.chromium.org/2690013002
Cr-Commit-Position: refs/heads/master@{#449929}
Committed: https://chromium.googlesource.com/chromium/src/+/b18851a60fd1a0820c00185bd660fc52bec31648

[msramek, 2017-02-13 09:25:14]

The CQ bit was checked by msramek@chromium.org

[msramek, 2017-02-13 09:25:14]

Created Revert of Stop MenuItemView From Directly Caching MenuController

[commit-bot: I haz the power, 2017-02-13 09:25:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 10:28:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 10:28:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msramek, 2017-02-13 10:34:21]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2017-02-13 10:34:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 10:58:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486982061028610, "parent_rev":
"157413286770a7ac5a24c446a30c08f749738276", "commit_rev":
"b18851a60fd1a0820c00185bd660fc52bec31648"}

[commit-bot: I haz the power, 2017-02-13 10:59:28]

Description was changed from

==========
Revert of Stop MenuItemView From Directly Caching MenuController (patchset #1
id:1 of https://codereview.chromium.org/2684993009/ )

Reason for revert:
Significant memory leak caught by ChromeOS ASan/LSan in the test added by this
CL.

For details, please see:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

Original issue's description:
> Stop MenuItemView From Directly Caching MenuController
> 
> When a MenuController closes its associated Widget is destroyed later on the
> MessageLoop. Due to this it is possible for a MenuHostRootView to receive
input
> while the associated MenuController has been destroyed.
> 
> MenuHostRootView accesses the MenuController through MenuItemView which simply
> caches it. This change updates MenuItemView to take a WeakPtr to the
controller.
> 
> TEST=MenuControllerTest.HostReceivesInputBeforeDestruction
> BUG=690097
> 
> Review-Url: https://codereview.chromium.org/2684993009
> Cr-Commit-Position: refs/heads/master@{#449663}
> Committed:
https://chromium.googlesource.com/chromium/src/+/549b48a07f5ac2def1b8ad0549f3...

TBR=sky@chromium.org,jonross@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=690097
==========

to

==========
Revert of Stop MenuItemView From Directly Caching MenuController (patchset #1
id:1 of https://codereview.chromium.org/2684993009/ )

Reason for revert:
Significant memory leak caught by ChromeOS ASan/LSan in the test added by this
CL.

For details, please see:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

Original issue's description:
> Stop MenuItemView From Directly Caching MenuController
> 
> When a MenuController closes its associated Widget is destroyed later on the
> MessageLoop. Due to this it is possible for a MenuHostRootView to receive
input
> while the associated MenuController has been destroyed.
> 
> MenuHostRootView accesses the MenuController through MenuItemView which simply
> caches it. This change updates MenuItemView to take a WeakPtr to the
controller.
> 
> TEST=MenuControllerTest.HostReceivesInputBeforeDestruction
> BUG=690097
> 
> Review-Url: https://codereview.chromium.org/2684993009
> Cr-Commit-Position: refs/heads/master@{#449663}
> Committed:
https://chromium.googlesource.com/chromium/src/+/549b48a07f5ac2def1b8ad0549f3...

TBR=sky@chromium.org,jonross@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=690097

Review-Url: https://codereview.chromium.org/2690013002
Cr-Commit-Position: refs/heads/master@{#449929}
Committed:
https://chromium.googlesource.com/chromium/src/+/b18851a60fd1a0820c00185bd660...
==========

[commit-bot: I haz the power, 2017-02-13 10:59:29]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b18851a60fd1a0820c00185bd660...