Run angle_white_box_tests on Win GPU.FYI

Run angle_white_box_tests on Win GPU.FYI

These tests were split off angle_end2end_tests (which are now black box),
so this restores them back to running on the bots.

Run only on Windows bots, as for now this is the only platform
which has white box tests, and running 0 tests is considered a failure
by some platforms (i.e. Android).

BUG=691136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2689873002
Cr-Commit-Position: refs/heads/master@{#450975}
Committed: https://chromium.googlesource.com/chromium/src/+/55e66c2991a9b0a16932a5b5c16951aa20b486b0

[ynovikov, 2017-02-11 02:31:07]

Description was changed from

==========
Run angle_white_box_tests on Win GPU.FYI

These tests were split off angle_end2end_tests (which are now black box),
so this restores them back to running on the bots.

Run only on Windows bots, as for now this is the only platform
which has white box tests, and running 0 tests is considered a failure
by some platforms (i.e. Android).

BUG=691136
==========

to

==========
Run angle_white_box_tests on Win GPU.FYI

These tests were split off angle_end2end_tests (which are now black box),
so this restores them back to running on the bots.

Run only on Windows bots, as for now this is the only platform
which has white box tests, and running 0 tests is considered a failure
by some platforms (i.e. Android).

BUG=691136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[ynovikov, 2017-02-11 02:31:28]

The CQ bit was checked by ynovikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 02:32:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ynovikov, 2017-02-11 02:32:13]

ynovikov@chromium.org changed reviewers:
+ dpranke@chromium.org, jmadill@chromium.org, kbr@chromium.org

[Dirk Pranke, 2017-02-11 02:41:35]

lgtm if/when the others are happy.

[commit-bot: I haz the power, 2017-02-11 03:19:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 03:19:16]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[ynovikov, 2017-02-11 03:21:31]

The CQ bit was checked by ynovikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 03:21:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 04:51:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 04:51:15]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Jamie Madill, 2017-02-12 00:02:01]

lgtm - Looks like we'll have to investigate those failures.

https://codereview.chromium.org/2689873002/diff/1/content/test/gpu/generate_b...
File content/test/gpu/generate_buildbot_json.py (right):

https://codereview.chromium.org/2689873002/diff/1/content/test/gpu/generate_b...
content/test/gpu/generate_buildbot_json.py:1170: # There are only Windows white
box tests
should probably comment that we should run these on other configs as tests are
added.

https://codereview.chromium.org/2689873002/diff/1/content/test/gpu/generate_b...
content/test/gpu/generate_buildbot_json.py:1175: '--use-gpu-in-tests',
pretty sure this argument does nothing and can be removed.

[Ken Russell (switch to Gerrit), 2017-02-14 02:25:12]

A couple of the new tests are crashing, i.e.:

[ RUN      ] D3DTextureTest.Clear/ES2_OPENGL
Backtrace:
	SafeRelease<IUnknown *> [0x0034C7B3+16]
	rx::D3DTextureSurfaceWGL::~D3DTextureSurfaceWGL [0x003BFE87+175]
	rx::D3DTextureSurfaceWGL::`scalar deleting destructor' [0x003BFEF6+11]
	SafeDelete<rx::VertexDataManager> [0x002C34EF+19]
	egl::Surface::~Surface [0x0030715E+95]
	egl::WindowSurface::`scalar deleting destructor' [0x003071AB+17]
	egl::Surface::setIsCurrent [0x0030792B+213]
	gl::Context::releaseSurface [0x002BF2A8+112]
	gl::Context::destroy [0x002BA6FD+235]
	egl::Display::destroyContext [0x002F2F0C+15]
	egl::DestroyContext [0x0040A05F+151]
	EGLWindow::destroyGL [0x0029C085+41]
	ANGLETest::TearDown [0x00225D1B+190]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void>
[0x0028F3D5+32]
	testing::Test::Run [0x00295B90+126]
	testing::TestInfo::Run [0x00295CF0+126]
	testing::TestCase::Run [0x00295C1B+133]
	testing::internal::UnitTestImpl::RunAllTests [0x00295F9A+433]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
[0x0028F419+32]
	testing::UnitTest::Run [0x00295DC4+133]
	base::TestSuite::Run [0x00284821+95]
	base::internal::Invoker<base::internal::BindState<int
(__cdecl*)(base::TestSuite *),base::internal::UnretainedWrapper<base::TestSuite>
>,int __cdecl(void)>::Run [0x0022CCE8+48]
	base::internal::Invoker<base::internal::BindState<int
(__cdecl*)(base::TestSuite *),base::internal::UnretainedWrapper<base::TestSuite>
>,int __cdecl(void)>::Run [0x0022CCC6+14]
	base::internal::RunMixin<base::Callback<void __cdecl(void),1,1> >::Run
[0x002832DB+25]
	rx::ShaderVk::getDebugInfo [0x00282BD7+684]
	base::LaunchUnitTestsWithOptions [0x00282C31+73]
	main [0x0022CD99+152]
	__scrt_common_main_seh [0x00551D19+249]
(f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x762D338A+18]
	RtlInitializeExceptionChain [0x76ED9902+99]
	RtlInitializeExceptionChain [0x76ED98D5+54]


LGTM once the try runs are green.

[ynovikov, 2017-02-14 20:40:33]

The CQ bit was checked by ynovikov@chromium.org

[commit-bot: I haz the power, 2017-02-14 20:41:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ynovikov, 2017-02-14 20:52:10]

The CQ bit was unchecked by ynovikov@chromium.org

[ynovikov, 2017-02-14 21:39:20]

The CQ bit was checked by ynovikov@chromium.org

[commit-bot: I haz the power, 2017-02-14 21:39:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 21:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 21:54:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Russell (switch to Gerrit), 2017-02-14 23:16:11]

On 2017/02/14 21:54:10, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Yuly, it looks like you need to rebase and re-run generate_buildbot_json.py.

[ynovikov, 2017-02-16 00:33:42]

https://codereview.chromium.org/2689873002/diff/1/content/test/gpu/generate_b...
File content/test/gpu/generate_buildbot_json.py (right):

https://codereview.chromium.org/2689873002/diff/1/content/test/gpu/generate_b...
content/test/gpu/generate_buildbot_json.py:1170: # There are only Windows white
box tests
On 2017/02/12 00:02:01, Jamie Madill wrote:
> should probably comment that we should run these on other configs as tests are
> added. 

Done.

https://codereview.chromium.org/2689873002/diff/1/content/test/gpu/generate_b...
content/test/gpu/generate_buildbot_json.py:1175: '--use-gpu-in-tests',
On 2017/02/12 00:02:01, Jamie Madill wrote:
> pretty sure this argument does nothing and can be removed.

Done.
(I've search for its usage, and it looks like this flag affects Chrome, but
wouldn't affect ANGLE tests. Seems like it should be removed in all ANGLE tests,
then).

[ynovikov, 2017-02-16 00:33:48]

The CQ bit was checked by ynovikov@chromium.org

[ynovikov, 2017-02-16 00:33:49]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
dpranke@chromium.org, jmadill@chromium.org
Link to the patchset: https://codereview.chromium.org/2689873002/#ps20001
(title: "review + rebase")

[commit-bot: I haz the power, 2017-02-16 00:36:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 01:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:27:17]

Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Ken Russell (switch to Gerrit), 2017-02-16 01:40:21]

Description was changed from

==========
Run angle_white_box_tests on Win GPU.FYI

These tests were split off angle_end2end_tests (which are now black box),
so this restores them back to running on the bots.

Run only on Windows bots, as for now this is the only platform
which has white box tests, and running 0 tests is considered a failure
by some platforms (i.e. Android).

BUG=691136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Run angle_white_box_tests on Win GPU.FYI

These tests were split off angle_end2end_tests (which are now black box),
so this restores them back to running on the bots.

Run only on Windows bots, as for now this is the only platform
which has white box tests, and running 0 tests is considered a failure
by some platforms (i.e. Android).

BUG=691136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-02-16 01:41:38]

On 2017/02/16 01:27:17, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

That's fallout from http://crbug.com/692823 . Should already be fixed on the CQ.
Re-CQ'ing.

[Ken Russell (switch to Gerrit), 2017-02-16 01:41:45]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:42:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ynovikov, 2017-02-16 01:46:56]

On 2017/02/16 01:41:38, Ken Russell wrote:
> On 2017/02/16 01:27:17, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
> 
> That's fallout from http://crbug.com/692823 . Should already be fixed on the
CQ.
> Re-CQ'ing.

Thanks!
I thought there used to be a "without patch" step, which would deduce that the
problem is in tree and not in the CL?

[Ken Russell (switch to Gerrit), 2017-02-16 02:32:25]

On 2017/02/16 01:46:56, ynovikov wrote:
> On 2017/02/16 01:41:38, Ken Russell wrote:
> > On 2017/02/16 01:27:17, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
> > 
> > That's fallout from http://crbug.com/692823 . Should already be fixed on the
> CQ.
> > Re-CQ'ing.
> 
> Thanks!
> I thought there used to be a "without patch" step, which would deduce that the
> problem is in tree and not in the CL?

We deliberately turned off retries without the patch on the optional tryservers
because they're too expensive. The Telemetry based harnesses don't understand
yet how to run just the failing subset of the tests, so they launch a whole
other WebGL 2.0 conformance run, which is prohibitively expensive.

[commit-bot: I haz the power, 2017-02-16 02:41:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 02:41:06]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[ynovikov, 2017-02-16 02:57:40]

On 2017/02/16 02:41:06, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build
> URL)
>   linux_chromium_asan_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
> no build URL)
>   linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
> build URL)
>   linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
> no build URL)
>   linux_optional_gpu_tests_rel on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)

CQ looks broken :-(

[Dirk Pranke, 2017-02-16 03:50:33]

It was. It should be getting better now, so please try again.

[ynovikov, 2017-02-16 03:59:33]

The CQ bit was checked by ynovikov@chromium.org

[commit-bot: I haz the power, 2017-02-16 04:00:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 05:35:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 05:35:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Jamie Madill, 2017-02-16 14:21:41]

The CQ bit was checked by jmadill@chromium.org

[commit-bot: I haz the power, 2017-02-16 14:22:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 15:45:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487254901576860,
"parent_rev": "3de46235451a893a2d48e7bd4396e6f2ad8f467d", "commit_rev":
"55e66c2991a9b0a16932a5b5c16951aa20b486b0"}

[commit-bot: I haz the power, 2017-02-16 15:46:21]

Description was changed from

==========
Run angle_white_box_tests on Win GPU.FYI

These tests were split off angle_end2end_tests (which are now black box),
so this restores them back to running on the bots.

Run only on Windows bots, as for now this is the only platform
which has white box tests, and running 0 tests is considered a failure
by some platforms (i.e. Android).

BUG=691136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Run angle_white_box_tests on Win GPU.FYI

These tests were split off angle_end2end_tests (which are now black box),
so this restores them back to running on the bots.

Run only on Windows bots, as for now this is the only platform
which has white box tests, and running 0 tests is considered a failure
by some platforms (i.e. Android).

BUG=691136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2689873002
Cr-Commit-Position: refs/heads/master@{#450975}
Committed:
https://chromium.googlesource.com/chromium/src/+/55e66c2991a9b0a16932a5b5c169...
==========

[commit-bot: I haz the power, 2017-02-16 15:46:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/55e66c2991a9b0a16932a5b5c169...