Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2689773002: [Sync] Replace typedef with using. (Closed)

Created:
3 years, 10 months ago by skym
Modified:
3 years, 10 months ago
Reviewers:
pavely
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, pkl (ping after 24h if needed), net-reviews_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, chromium-apps-reviews_chromium.org, sync-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Replace typedef with using. Guidance is to prefer using over typedef https://chromium-cpp.appspot.com/ https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/8dOAMzgR4ao This change was programmatically performed with the following: > find components/sync/ components/sync_bookmarks/ \ components/sync_sessions/ components/browser_sync/ \ chrome/browser/sync/ chrome/browser/ui/sync ios/chrome/browser/sync \ ios/chrome/browser/ui/webui/sync_internals | grep "\.cc\|\.h" | xargs \ perl -0777 -i -pe 's/(\n[^\/]*?)typedef ([\s\S]*?) \ ([a-zA-Z_]+);/$1using $3 = $2;/g' > git add * > git cl format BUG= Review-Url: https://codereview.chromium.org/2689773002 Cr-Commit-Position: refs/heads/master@{#450989} Committed: https://chromium.googlesource.com/chromium/src/+/60bd4d2f4ebb73c4959e960c269ac0326889eb44

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : [Sync] Replace typedef with using. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -284 lines) Patch
M chrome/browser/sync/profile_sync_service_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/await_match_status_change_checker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/migration_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/search_engines_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_app_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_links_delegate_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.h View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/browser_sync/profile_sync_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service_bookmark_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/browser_sync/profile_sync_test_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/base/attachment_id_proto_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/cryptographer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/enum_set.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/base/enum_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/extensions_activity.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/immutable.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/immutable_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/base/model_type.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sync/base/node_ordinal.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/ordinal_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/base/progress_marker_map.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/proto_value_ptr_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/sync_prefs.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/device_info/device_count_metrics_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/device_info/device_info_sync_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/device_info/local_device_info_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/data_type_controller.h View 1 chunk +9 lines, -11 lines 0 comments Download
M components/sync/driver/data_type_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/data_type_status_table.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/generic_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/shared_change_processor.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sync/driver/sync_api_component_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sync/driver/sync_stopped_reporter.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine/attachments/attachment_downloader.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/sync/engine/attachments/attachment_uploader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/engine/attachments/in_memory_attachment_store.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine/model_safe_worker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine/net/http_post_provider_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine/net/network_time_update_callback.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/sync/engine/non_blocking_sync_common.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/engine/sync_auth_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/engine/sync_engine.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sync/engine/sync_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/attachments/attachment_downloader_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sync/engine_impl/attachments/attachment_downloader_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/attachments/attachment_uploader_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/attachments/attachment_uploader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/commit.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/commit_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/debug_info_event_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/debug_info_event_listener_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/get_updates_processor.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/model_type_registry.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/sync/engine_impl/process_updates_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/sync_manager_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/sync_scheduler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/sync_scheduler_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/syncer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/update_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/uss_migrator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/js/js_event_details.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/model/attachments/attachment.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/model/attachments/attachment_id.h View 3 chunks +5 lines, -6 lines 0 comments Download
M components/sync/model/attachments/attachment_metadata.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/attachments/attachment_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/model/attachments/attachment_store.h View 1 chunk +9 lines, -10 lines 0 comments Download
M components/sync/model/data_batch.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/data_type_error_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/data_type_error_handler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/entity_change.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/entity_data.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/model/metadata_batch.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/mock_model_type_store.h View 1 chunk +14 lines, -15 lines 0 comments Download
M components/sync/model/model_type_change_processor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/model/model_type_store.h View 1 chunk +17 lines, -17 lines 0 comments Download
M components/sync/model/model_type_sync_bridge.h View 1 chunk +4 lines, -6 lines 0 comments Download
M components/sync/model/string_ordinal.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/sync_change_processor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/model/sync_change_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/sync_data.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/sync/model/sync_error_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/sync_merge_result_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/syncable_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model_impl/attachments/task_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model_impl/model_type_store_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/change_record.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/syncable/change_reorder_buffer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sync/syncable/change_reorder_buffer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/syncable/delete_journal.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/directory.h View 1 chunk +9 lines, -9 lines 0 comments Download
M components/sync/syncable/directory_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/entry_kernel.h View 2 chunks +10 lines, -11 lines 0 comments Download
M components/sync/syncable/metahandle_set.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/nigori_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/parent_child_index.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/sync/syncable/syncable_delete_journal.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/syncable/write_transaction_info.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/test/engine/mock_model_type_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/test/fake_server/fake_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/test/fake_server/sessions_hierarchy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.h View 1 chunk +6 lines, -6 lines 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/sync_sessions/favicon_cache.h View 1 chunk +5 lines, -5 lines 0 comments Download
M components/sync_sessions/lost_navigations_recorder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_sessions/lost_navigations_recorder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/tab_node_pool.h View 2 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/sync_setup_service.h View 3 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 31 (24 generated)
skym
PTAL
3 years, 10 months ago (2017-02-10 22:15:15 UTC) #12
pavely
lgtm
3 years, 10 months ago (2017-02-12 01:03:25 UTC) #13
commit-bot: I haz the power
This CL has an open dependency (Issue 2672493002 Patch 60001). Please resolve the dependency and ...
3 years, 10 months ago (2017-02-13 16:07:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689773002/40001
3 years, 10 months ago (2017-02-15 17:28:39 UTC) #23
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 10 months ago (2017-02-15 22:09:48 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689773002/40001
3 years, 10 months ago (2017-02-16 16:32:42 UTC) #28
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 16:43:11 UTC) #31
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/60bd4d2f4ebb73c4959e960c269a...

Powered by Google App Engine
This is Rietveld 408576698