Various cleanups in VTTRegion

Various cleanups in VTTRegion

 * Eliminate single-use pseudo-id functions (and associated statics)

 * Avoid redundant calls to getBoundingClientRect, and use
   ClientRect::height where appropriate.

 * Allow using ElementTraversal::childrenOf in
   VTTRegion::displayLastVTTCueBox by putting a break after
   startTimer().

 * Get rid of VTTRegion::m_settings and updateParametersFromRegion
   (they are not used.)

 * Replace 'long' with 'int' for lines, because that matches the
   WebIDL type better.

 * Remove unused includes (add more specific ones when needed.)

Review-Url: https://codereview.chromium.org/2689703002
Cr-Commit-Position: refs/heads/master@{#449790}
Committed: https://chromium.googlesource.com/chromium/src/+/621d3a7e8220105302d9ceb646463fcdd729625c

[fs, 2017-02-10 14:42:32]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 14:42:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-02-10 15:45:37]

fs@opera.com changed reviewers:
+ foolip@chromium.org

[fs, 2017-02-10 15:45:38]

Some (simple) stuff I noticed while visiting this code...

[commit-bot: I haz the power, 2017-02-10 16:30:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 16:30:18]

Dry run: This issue passed the CQ dry run.

[foolip, 2017-02-10 23:34:33]

The CQ bit was checked by foolip@chromium.org

[foolip, 2017-02-10 23:34:33]

lgtm

[commit-bot: I haz the power, 2017-02-10 23:34:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 23:43:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486769673206820, "parent_rev":
"8b137c363843aa9d1bb7783bb364a0584e238d6f", "commit_rev":
"621d3a7e8220105302d9ceb646463fcdd729625c"}

[commit-bot: I haz the power, 2017-02-10 23:43:51]

Description was changed from

==========
Various cleanups in VTTRegion

 * Eliminate single-use pseudo-id functions (and associated statics)

 * Avoid redundant calls to getBoundingClientRect, and use
   ClientRect::height where appropriate.

 * Allow using ElementTraversal::childrenOf in
   VTTRegion::displayLastVTTCueBox by putting a break after
   startTimer().

 * Get rid of VTTRegion::m_settings and updateParametersFromRegion
   (they are not used.)

 * Replace 'long' with 'int' for lines, because that matches the
   WebIDL type better.

 * Remove unused includes (add more specific ones when needed.)
==========

to

==========
Various cleanups in VTTRegion

 * Eliminate single-use pseudo-id functions (and associated statics)

 * Avoid redundant calls to getBoundingClientRect, and use
   ClientRect::height where appropriate.

 * Allow using ElementTraversal::childrenOf in
   VTTRegion::displayLastVTTCueBox by putting a break after
   startTimer().

 * Get rid of VTTRegion::m_settings and updateParametersFromRegion
   (they are not used.)

 * Replace 'long' with 'int' for lines, because that matches the
   WebIDL type better.

 * Remove unused includes (add more specific ones when needed.)

Review-Url: https://codereview.chromium.org/2689703002
Cr-Commit-Position: refs/heads/master@{#449790}
Committed:
https://chromium.googlesource.com/chromium/src/+/621d3a7e8220105302d9ceb64646...
==========

[commit-bot: I haz the power, 2017-02-10 23:43:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/621d3a7e8220105302d9ceb64646...