[heap] Fix address space leak in Unmapper

[heap] Fix address space leak in Unmapper

BUG=v8:5945
Review-Url: https://codereview.chromium.org/2689683002
Cr-Commit-Position: refs/heads/master@{#43102}
Committed: https://chromium.googlesource.com/v8/v8/+/504d0e5979c8bdac33a203a1c9353ca2047330d5

[Michael Lippautz, 2017-02-10 12:08:44]

Description was changed from

==========
[heap] Fix address space leak in Unmapper

BUG=
==========

to

==========
[heap] Fix address space leak in Unmapper

BUG=
==========

[Michael Lippautz, 2017-02-10 12:08:44]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org, jochen@chromium.org

[Michael Lippautz, 2017-02-10 12:08:59]

Description was changed from

==========
[heap] Fix address space leak in Unmapper

BUG=
==========

to

==========
[heap] Fix address space leak in Unmapper

BUG=v8:5945
==========

[jochen (gone - plz use gerrit), 2017-02-10 12:27:13]

lgtm

[Hannes Payer (out of office), 2017-02-10 12:29:22]

lgtm

https://codereview.chromium.org/2689683002/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/2689683002/diff/1/src/heap/spaces.cc#newcode387
src/heap/spaces.cc:387: MemoryChunk* chunk = nullptr;
Let's wrap that into a function with a proper name to immediately see the
difference to PerformFreeMemoryOnQueuedChunks.

https://codereview.chromium.org/2689683002/diff/1/src/heap/spaces.cc#newcode398
src/heap/spaces.cc:398: }
Let's verify here that all lists are empty.

[Michael Lippautz, 2017-02-10 13:17:57]

Patchset #2 (id:20001) has been deleted

[Michael Lippautz, 2017-02-10 13:18:33]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 13:18:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 13:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 13:27:15]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[Michael Lippautz, 2017-02-10 13:34:08]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[Michael Lippautz, 2017-02-10 13:34:12]

https://codereview.chromium.org/2689683002/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/2689683002/diff/1/src/heap/spaces.cc#newcode387
src/heap/spaces.cc:387: MemoryChunk* chunk = nullptr;
On 2017/02/10 12:29:22, Hannes Payer wrote:
> Let's wrap that into a function with a proper name to immediately see the
> difference to PerformFreeMemoryOnQueuedChunks.

Done. Unified into a single function.

https://codereview.chromium.org/2689683002/diff/1/src/heap/spaces.cc#newcode398
src/heap/spaces.cc:398: }
On 2017/02/10 12:29:22, Hannes Payer wrote:
> Let's verify here that all lists are empty.

Done.

[commit-bot: I haz the power, 2017-02-10 13:34:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 14:01:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 14:01:29]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2017-02-10 14:24:42]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2017-02-10 14:24:42]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2689683002/#ps60001
(title: "Windows compile fixes")

[commit-bot: I haz the power, 2017-02-10 14:24:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 14:26:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486736682410190,
"parent_rev": "6c12d57eada07ab019f84b2882faee6e2815a7ff", "commit_rev":
"504d0e5979c8bdac33a203a1c9353ca2047330d5"}

[commit-bot: I haz the power, 2017-02-10 14:26:09]

Description was changed from

==========
[heap] Fix address space leak in Unmapper

BUG=v8:5945
==========

to

==========
[heap] Fix address space leak in Unmapper

BUG=v8:5945

Review-Url: https://codereview.chromium.org/2689683002
Cr-Commit-Position: refs/heads/master@{#43102}
Committed:
https://chromium.googlesource.com/v8/v8/+/504d0e5979c8bdac33a203a1c9353ca2047...
==========

[commit-bot: I haz the power, 2017-02-10 14:26:10]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/504d0e5979c8bdac33a203a1c9353ca2047...