Flush errors when destroying a passthrough command decoder.

Flush errors when destroying a passthrough command decoder.

Sometimes the context would be re-used after destroying a command
decoder and would fail initialization of a new command decoder because
errors were already present on the context.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2689673004
Cr-Commit-Position: refs/heads/master@{#449868}
Committed: https://chromium.googlesource.com/chromium/src/+/3c0f2dc2a8d781fcd7f8ddbb85ab27fb30255f2a

[Geoff Lang, 2017-02-10 20:36:21]

Description was changed from

==========
Flush errors when destroying a passthrough command decoder.

Sometimes the context would be re-used after destroying a command
decoder and would fail initialization of a new command decoder because
errors were already present on the context.

BUG=602737
==========

to

==========
Flush errors when destroying a passthrough command decoder.

Sometimes the context would be re-used after destroying a command
decoder and would fail initialization of a new command decoder because
errors were already present on the context.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-02-10 20:43:06]

Description was changed from

==========
Flush errors when destroying a passthrough command decoder.

Sometimes the context would be re-used after destroying a command
decoder and would fail initialization of a new command decoder because
errors were already present on the context.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Flush errors when destroying a passthrough command decoder.

Sometimes the context would be re-used after destroying a command
decoder and would fail initialization of a new command decoder because
errors were already present on the context.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-02-10 20:43:06]

geofflang@chromium.org changed reviewers:
+ zmo@chromium.org

[Geoff Lang, 2017-02-10 20:43:14]

PTAL

[Geoff Lang, 2017-02-10 20:43:18]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 20:43:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2017-02-10 20:57:49]

On 2017/02/10 20:43:14, Geoff Lang wrote:
> PTAL

LGTM

What's the benefit of reusing a destroyed context, not creating a new one? just
asking

[commit-bot: I haz the power, 2017-02-10 22:04:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:04:29]

Dry run: This issue passed the CQ dry run.

[Geoff Lang, 2017-02-11 17:01:03]

On 2017/02/10 20:57:49, Zhenyao Mo wrote:
> On 2017/02/10 20:43:14, Geoff Lang wrote:
> > PTAL
> 
> LGTM
> 
> What's the benefit of reusing a destroyed context, not creating a new one?
just
> asking

I updated the fuzzer to do exactly that but I figured I should fix this as well.

[Geoff Lang, 2017-02-11 17:01:25]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2017-02-11 17:01:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 17:09:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486832485321270, "parent_rev":
"4a503e85de502aa541cae933a6cc7b6586b5b9cf", "commit_rev":
"3c0f2dc2a8d781fcd7f8ddbb85ab27fb30255f2a"}

[commit-bot: I haz the power, 2017-02-11 17:09:39]

Description was changed from

==========
Flush errors when destroying a passthrough command decoder.

Sometimes the context would be re-used after destroying a command
decoder and would fail initialization of a new command decoder because
errors were already present on the context.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Flush errors when destroying a passthrough command decoder.

Sometimes the context would be re-used after destroying a command
decoder and would fail initialization of a new command decoder because
errors were already present on the context.

BUG=602737
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2689673004
Cr-Commit-Position: refs/heads/master@{#449868}
Committed:
https://chromium.googlesource.com/chromium/src/+/3c0f2dc2a8d781fcd7f8ddbb85ab...
==========

[commit-bot: I haz the power, 2017-02-11 17:09:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c0f2dc2a8d781fcd7f8ddbb85ab...