Chromium Code Reviews| Index: content/browser/frame_host/navigation_handle_impl.h |
| diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h |
| index bd536c5a50fda144fb133550f211478abd9d08d6..381093d5e4370005f01e832dbcbce4792619bdf9 100644 |
| --- a/content/browser/frame_host/navigation_handle_impl.h |
| +++ b/content/browser/frame_host/navigation_handle_impl.h |
| @@ -93,7 +93,8 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle { |
| const base::TimeTicks& navigation_start, |
| int pending_nav_entry_id, |
| bool started_from_context_menu, |
| - bool should_bypass_main_world_csp); |
| + bool should_bypass_main_world_csp, |
| + bool is_form_submission); |
|
nasko
2017/03/16 21:49:47
There are too many booleans on this method. It mig
arthursonzogni
2017/03/17 14:58:25
Yes, I will be happy to fix this in a follow up.
S
|
| ~NavigationHandleImpl() override; |
| // Used to track the state the navigation is currently in. |
| @@ -170,6 +171,11 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle { |
| // Used in tests. |
| State state_for_testing() const { return state_; } |
| + // Whether or not the navigation has been initiated by a form submission. |
| + // TODO(arthursonzogni) This value is correct only when PlzNavigate is |
|
nasko
2017/03/16 21:49:47
nit: ":" after the TODO().
arthursonzogni
2017/03/17 14:58:25
Done.
|
| + // enabled. Make it work in both mode. |
|
nasko
2017/03/16 21:49:47
nit: modes.
alexmos
2017/03/16 23:05:36
nit: s/mode/modes/
arthursonzogni
2017/03/17 14:58:25
Done.
arthursonzogni
2017/03/17 14:58:25
Done.
|
| + bool is_form_submission() const { return is_form_submission_; } |
| + |
| // The NavigatorDelegate to notify/query for various navigation events. |
| // Normally this is the WebContents, except if this NavigationHandle was |
| // created during a navigation to an interstitial page. In this case it will |
| @@ -367,7 +373,8 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle { |
| const base::TimeTicks& navigation_start, |
| int pending_nav_entry_id, |
| bool started_from_context_menu, |
| - bool should_bypass_main_world_csp); |
| + bool should_bypass_main_world_csp, |
| + bool is_form_submission); |
| NavigationThrottle::ThrottleCheckResult CheckWillStartRequest(); |
| NavigationThrottle::ThrottleCheckResult CheckWillRedirectRequest(); |
| @@ -526,6 +533,9 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle { |
| // blocked by the parent frame's CSP. |
| bool should_bypass_main_world_csp_; |
| + // Whether or not the navigation results from the submission of a form. |
| + bool is_form_submission_; |
| + |
| base::WeakPtrFactory<NavigationHandleImpl> weak_factory_; |
| DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl); |