PlzNavigate: Enforce 'form-action' CSP on the browser-side.

content/browser/frame_host/navigation_handle_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
 
 #include "content/public/browser/navigation_handle.h"
 
 #include <stddef.h>
@@ skipping 75 matching lines @@
   // associated with this navigation.
   static std::unique_ptr<NavigationHandleImpl> Create(
       const GURL& url,
       const std::vector<GURL>& redirect_chain,
       FrameTreeNode* frame_tree_node,
       bool is_renderer_initiated,
       bool is_same_page,
       const base::TimeTicks& navigation_start,
       int pending_nav_entry_id,
       bool started_from_context_menu,
-      bool should_bypass_main_world_csp);
+      bool should_bypass_main_world_csp,
+      bool is_form_submission);

[nasko, 2017/03/16 21:49:47]

There are too many booleans on this method. It might be useful to follow up
later on and convert them to enums, so they are more meaningful when reading the
callers of this method.

[arthursonzogni, 2017/03/17 14:58:25]

Yes, I will be happy to fix this in a follow up.
See https://crbug.com/702557

   ~NavigationHandleImpl() override;
 
   // Used to track the state the navigation is currently in.
   enum State {
     INITIAL = 0,
     WILL_SEND_REQUEST,
     DEFERRING_START,
     WILL_REDIRECT_REQUEST,
     DEFERRING_REDIRECT,
     CANCELING,
@@ skipping 56 matching lines @@
   const std::string& GetSearchableFormEncoding() override;
   ReloadType GetReloadType() override;
   RestoreType GetRestoreType() override;
   const GlobalRequestID& GetGlobalRequestID() override;
 
   NavigationData* GetNavigationData() override;
 
   // Used in tests.
   State state_for_testing() const { return state_; }
 
+  // Whether or not the navigation has been initiated by a form submission.
+  // TODO(arthursonzogni) This value is correct only when PlzNavigate is

[nasko, 2017/03/16 21:49:47]

nit: ":" after the TODO().

[arthursonzogni, 2017/03/17 14:58:25]

Done.

+  // enabled. Make it work in both mode.

[nasko, 2017/03/16 21:49:47]

nit: modes.

[alexmos, 2017/03/16 23:05:36]

nit: s/mode/modes/

[arthursonzogni, 2017/03/17 14:58:25]

Done.

[arthursonzogni, 2017/03/17 14:58:25]

Done.

+  bool is_form_submission() const { return is_form_submission_; }
+
   // The NavigatorDelegate to notify/query for various navigation events.
   // Normally this is the WebContents, except if this NavigationHandle was
   // created during a navigation to an interstitial page. In this case it will
   // be the InterstitialPage itself.
   //
   // Note: due to the interstitial navigation case, all calls that can possibly
   // expose the NavigationHandle to code outside of content/ MUST go though the
   // NavigatorDelegate. In particular, the ContentBrowserClient should not be
   // called directly form the NavigationHandle code. Thus, these calls will not
   // expose the NavigationHandle when navigating to an InterstialPage.
@@ skipping 177 matching lines @@
   friend class NavigationHandleImplTest;
 
   NavigationHandleImpl(const GURL& url,
                        const std::vector<GURL>& redirect_chain,
                        FrameTreeNode* frame_tree_node,
                        bool is_renderer_initiated,
                        bool is_same_page,
                        const base::TimeTicks& navigation_start,
                        int pending_nav_entry_id,
                        bool started_from_context_menu,
-                       bool should_bypass_main_world_csp);
+                       bool should_bypass_main_world_csp,
+                       bool is_form_submission);
 
   NavigationThrottle::ThrottleCheckResult CheckWillStartRequest();
   NavigationThrottle::ThrottleCheckResult CheckWillRedirectRequest();
   NavigationThrottle::ThrottleCheckResult CheckWillProcessResponse();
 
   // Called when WillProcessResponse checks are done, to find the final
   // RenderFrameHost for the navigation. Checks whether the navigation should be
   // transferred. Returns false if the transfer attempt results in the
   // destruction of this NavigationHandle and the navigation should no longer
   // proceed. This can happen when the RenderFrameHostManager determines a
@@ skipping 138 matching lines @@
   GURL previous_url_;
   GURL base_url_;
   net::HostPortPair socket_address_;
   NavigationType navigation_type_;
 
   // Whether or not the navigation has been issued by an isolated world, for
   // instance from a chrome extension. When true, the navigation should not be
   // blocked by the parent frame's CSP.
   bool should_bypass_main_world_csp_;
 
+  // Whether or not the navigation results from the submission of a form.
+  bool is_form_submission_;
+
   base::WeakPtrFactory<NavigationHandleImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_