Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2689633002: Change the default button of Network Wifi config dialog back to 'Connect'. (Closed)

Created:
3 years, 10 months ago by xdai1
Modified:
3 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the default button of Network Wifi config dialog back to 'Connect'. The default button was changed from 'Connect' to 'Cancel' in https://codereview.chromium.org/2659973003, which caused the regression. BUG=689795 Review-Url: https://codereview.chromium.org/2689633002 Cr-Commit-Position: refs/heads/master@{#449503} Committed: https://chromium.googlesource.com/chromium/src/+/71afff610bb36f19c52564fc5801143fbeaab8f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/chromeos/options/network_config_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
xdai1
stevenjb@, could you help review this CL please? Thanks!
3 years, 10 months ago (2017-02-10 00:24:46 UTC) #2
stevenjb
lgtm
3 years, 10 months ago (2017-02-10 00:27:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689633002/1
3 years, 10 months ago (2017-02-10 00:29:27 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 01:24:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/71afff610bb36f19c52564fc5801...

Powered by Google App Engine
This is Rietveld 408576698