Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2689603003: Disable flaky generators-debug-scopes test (Closed)

Created:
3 years, 10 months ago by jgruber
Modified:
3 years, 10 months ago
CC:
ahaas, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable flaky generators-debug-scopes test This test is flaky when run with --optimize-for-size. BUG=v8:5950 Review-Url: https://codereview.chromium.org/2689603003 Cr-Commit-Position: refs/heads/master@{#43097} Committed: https://chromium.googlesource.com/v8/v8/+/fc1af41dadb095a0a54a6e6563e7dfa1acbf6025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/debugger/debugger.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
jgruber
3 years, 10 months ago (2017-02-10 12:58:24 UTC) #4
Michael Hablich
lgtm
3 years, 10 months ago (2017-02-10 13:04:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689603003/1
3 years, 10 months ago (2017-02-10 13:05:42 UTC) #8
Yang
lgtm
3 years, 10 months ago (2017-02-10 13:09:45 UTC) #9
Michael Achenbach
lgtm
3 years, 10 months ago (2017-02-10 13:14:16 UTC) #11
Michael Achenbach
On 2017/02/10 13:14:16, Michael Achenbach wrote: > lgtm Hint: Always use NOTRY=true for skipping tests. ...
3 years, 10 months ago (2017-02-10 13:15:23 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 13:23:35 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fc1af41dadb095a0a54a6e6563e7dfa1acb...

Powered by Google App Engine
This is Rietveld 408576698