Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2689593005: Send a correctly-formatted response if there are no host options saved. (Closed)

Created:
3 years, 10 months ago by Jamie
Modified:
3 years, 10 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send a correctly-formatted response if there are no host options saved. Previously, the response would be simply {}, which is interpreted as an error by the import code. Review-Url: https://codereview.chromium.org/2689593005 Cr-Commit-Position: refs/heads/master@{#450246} Committed: https://chromium.googlesource.com/chromium/src/+/f143318ec3d651b2cdee9a5edb7b011afbdb1510

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reviewer feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M remoting/webapp/crd/js/options_export.js View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Jamie
PTAL
3 years, 10 months ago (2017-02-10 18:57:37 UTC) #2
kelvinp
lgtm https://codereview.chromium.org/2689593005/diff/1/remoting/webapp/crd/js/options_export.js File remoting/webapp/crd/js/options_export.js (right): https://codereview.chromium.org/2689593005/diff/1/remoting/webapp/crd/js/options_export.js#newcode23 remoting/webapp/crd/js/options_export.js:23: chrome.storage.local.get('remoting-host-options', function(options) { put 'remoting-host-options' as a variable?
3 years, 10 months ago (2017-02-13 19:58:19 UTC) #3
Jamie
FYI https://codereview.chromium.org/2689593005/diff/1/remoting/webapp/crd/js/options_export.js File remoting/webapp/crd/js/options_export.js (right): https://codereview.chromium.org/2689593005/diff/1/remoting/webapp/crd/js/options_export.js#newcode23 remoting/webapp/crd/js/options_export.js:23: chrome.storage.local.get('remoting-host-options', function(options) { On 2017/02/13 19:58:19, kelvinp wrote: ...
3 years, 10 months ago (2017-02-14 02:48:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689593005/20001
3 years, 10 months ago (2017-02-14 02:49:11 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 04:34:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f143318ec3d651b2cdee9a5edb7b...

Powered by Google App Engine
This is Rietveld 408576698