Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2689593004: Add SK_IGNORE_DIRECTWRITE_GASP_FIX to Skia. (Closed)

Created:
3 years, 10 months ago by bungeman-chromium
Modified:
3 years, 10 months ago
Reviewers:
bungeman-skia
CC:
chromium-reviews, drott
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SK_IGNORE_DIRECTWRITE_GASP_FIX to Skia. This flag will hold out a rendering change in Skia with DirectWrite until the change can be rebaselined. BUG=chromium:645055 TBR=mtklein@chromium.org Trivial change which changes nothing right now. Review-Url: https://codereview.chromium.org/2689593004 Cr-Commit-Position: refs/heads/master@{#449691} Committed: https://chromium.googlesource.com/chromium/src/+/36eee2d8b1c6cb707df5a84c6d347c863596dd5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M skia/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
bungeman-skia
lgtm
3 years, 10 months ago (2017-02-10 16:41:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689593004/1
3 years, 10 months ago (2017-02-10 16:42:12 UTC) #4
bungeman-chromium
3 years, 10 months ago (2017-02-10 16:42:14 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-10 16:42:17 UTC) #7
bungeman-chromium
lgtm
3 years, 10 months ago (2017-02-10 16:42:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689593004/1
3 years, 10 months ago (2017-02-10 16:44:47 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 19:36:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36eee2d8b1c6cb707df5a84c6d34...

Powered by Google App Engine
This is Rietveld 408576698