Surfaces: Receive resources only once

Surfaces: Receive resources only once

ResourceRefs tracks the number of refs for a resource received from a
parent so that it can send back the same refs when the resource is no
longer used by the display compositor. Prior to this CL, we were
calling ReceiveRefs when a CompositorFrame is marked as pending and
again when it was activated. This causes us to doubly returns refs to
the client.

This CL calls ReceiveFromChild only once on Surface::QueueFrame (when
the frame is first received), and does not update the refs when a frame
goes from pending to active. If a pending or active frame is overwritten
refs are still returned.

BUG=672062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2689563005
Cr-Commit-Position: refs/heads/master@{#449770}
Committed: https://chromium.googlesource.com/chromium/src/+/5d87c3aad9d1276390112859ec0f6a4b3ca89adc

[Fady Samuel, 2017-02-10 19:30:12]

Description was changed from

==========
Surfaces: Receive resources only once

ResourceRefs tracks the number of refs for a resource received from a
child so that it can send back the same refs when the resource is no
longer used by the display compositor. Prior to this CL, we were
calling ReceiveRefs when a CompositorFrame is marked as pending and
again when it was activated. This causes us to doubly returns refs to
the client.

This CL calls ReceiveFromChild only once on Surface::QueueFrame (when
the frame is first received), and does not update the refs when a frame
goes from pending to active. If a pending or active frame is overwritten
refs are still returned.

BUG=672062
==========

to

==========
Surfaces: Receive resources only once

ResourceRefs tracks the number of refs for a resource received from a
child so that it can send back the same refs when the resource is no
longer used by the display compositor. Prior to this CL, we were
calling ReceiveRefs when a CompositorFrame is marked as pending and
again when it was activated. This causes us to doubly returns refs to
the client.

This CL calls ReceiveFromChild only once on Surface::QueueFrame (when
the frame is first received), and does not update the refs when a frame
goes from pending to active. If a pending or active frame is overwritten
refs are still returned.

BUG=672062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-02-10 19:31:28]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 19:33:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 19:52:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 19:52:47]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Fady Samuel, 2017-02-10 20:23:58]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2017-02-10 20:24:24]

Description was changed from

==========
Surfaces: Receive resources only once

ResourceRefs tracks the number of refs for a resource received from a
child so that it can send back the same refs when the resource is no
longer used by the display compositor. Prior to this CL, we were
calling ReceiveRefs when a CompositorFrame is marked as pending and
again when it was activated. This causes us to doubly returns refs to
the client.

This CL calls ReceiveFromChild only once on Surface::QueueFrame (when
the frame is first received), and does not update the refs when a frame
goes from pending to active. If a pending or active frame is overwritten
refs are still returned.

BUG=672062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Surfaces: Receive resources only once

ResourceRefs tracks the number of refs for a resource received from a
parent so that it can send back the same refs when the resource is no
longer used by the display compositor. Prior to this CL, we were
calling ReceiveRefs when a CompositorFrame is marked as pending and
again when it was activated. This causes us to doubly returns refs to
the client.

This CL calls ReceiveFromChild only once on Surface::QueueFrame (when
the frame is first received), and does not update the refs when a frame
goes from pending to active. If a pending or active frame is overwritten
refs are still returned.

BUG=672062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-02-10 20:24:48]

fsamuel@chromium.org changed reviewers:
+ vmpstr@chromium.org

[Fady Samuel, 2017-02-10 20:24:49]

+vmpstr@ for review
+rjkroege@, kylechar@ FYI

[commit-bot: I haz the power, 2017-02-10 20:24:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 21:54:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 21:54:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2017-02-10 22:06:17]

lgtm

[Fady Samuel, 2017-02-10 22:07:26]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:08:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 22:44:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486764446163020,
"parent_rev": "96b1db92fdad353c2702419886d5732574eaab33", "commit_rev":
"5d87c3aad9d1276390112859ec0f6a4b3ca89adc"}

[commit-bot: I haz the power, 2017-02-10 22:44:42]

Description was changed from

==========
Surfaces: Receive resources only once

ResourceRefs tracks the number of refs for a resource received from a
parent so that it can send back the same refs when the resource is no
longer used by the display compositor. Prior to this CL, we were
calling ReceiveRefs when a CompositorFrame is marked as pending and
again when it was activated. This causes us to doubly returns refs to
the client.

This CL calls ReceiveFromChild only once on Surface::QueueFrame (when
the frame is first received), and does not update the refs when a frame
goes from pending to active. If a pending or active frame is overwritten
refs are still returned.

BUG=672062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Surfaces: Receive resources only once

ResourceRefs tracks the number of refs for a resource received from a
parent so that it can send back the same refs when the resource is no
longer used by the display compositor. Prior to this CL, we were
calling ReceiveRefs when a CompositorFrame is marked as pending and
again when it was activated. This causes us to doubly returns refs to
the client.

This CL calls ReceiveFromChild only once on Surface::QueueFrame (when
the frame is first received), and does not update the refs when a frame
goes from pending to active. If a pending or active frame is overwritten
refs are still returned.

BUG=672062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2689563005
Cr-Commit-Position: refs/heads/master@{#449770}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d87c3aad9d1276390112859ec0f...
==========

[commit-bot: I haz the power, 2017-02-10 22:44:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5d87c3aad9d1276390112859ec0f...