Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2689563003: Use zone memory for StackTrace::ToCString. (Closed)

Created:
3 years, 10 months ago by rmacnak
Modified:
3 years, 10 months ago
Reviewers:
zra, Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use zone memory for StackTrace::ToCString. Fixes memory leak of the TextBuffer's buffer. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/4e8b265ea0c4d56d2e25f107d9a9cc4b975ef588

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -3 lines) Patch
M runtime/vm/object.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A runtime/vm/zone_text_buffer.h View 1 chunk +38 lines, -0 lines 2 comments Download
A runtime/vm/zone_text_buffer.cc View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rmacnak
3 years, 10 months ago (2017-02-09 19:26:49 UTC) #2
Florian Schneider
lgtm
3 years, 10 months ago (2017-02-09 20:30:23 UTC) #3
Cutch
On 2017/02/09 20:30:23, Florian Schneider wrote: > lgtm please stop making changes to stack traces ...
3 years, 10 months ago (2017-02-09 20:31:52 UTC) #4
Cutch
On 2017/02/09 20:31:52, Cutch wrote: > On 2017/02/09 20:30:23, Florian Schneider wrote: > > lgtm ...
3 years, 10 months ago (2017-02-09 20:32:08 UTC) #5
rmacnak
Committed patchset #1 (id:1) manually as 4e8b265ea0c4d56d2e25f107d9a9cc4b975ef588 (presubmit successful).
3 years, 10 months ago (2017-02-09 20:34:25 UTC) #8
rmacnak
On 2017/02/09 20:32:08, Cutch wrote: > On 2017/02/09 20:31:52, Cutch wrote: > > On 2017/02/09 ...
3 years, 10 months ago (2017-02-09 20:35:36 UTC) #9
zra
dbc https://codereview.chromium.org/2689563003/diff/1/runtime/vm/zone_text_buffer.h File runtime/vm/zone_text_buffer.h (right): https://codereview.chromium.org/2689563003/diff/1/runtime/vm/zone_text_buffer.h#newcode1 runtime/vm/zone_text_buffer.h:1: // Copyright (c) 2012, the Dart project authors. ...
3 years, 10 months ago (2017-02-09 20:37:48 UTC) #11
rmacnak
3 years, 10 months ago (2017-02-11 01:44:12 UTC) #12
Message was sent while issue was closed. 
https://codereview.chromium.org/2689563003/diff/1/runtime/vm/zone_text_buffer.h
File runtime/vm/zone_text_buffer.h (right):

https://codereview.chromium.org/2689563003/diff/1/runtime/vm/zone_text_buffer...
runtime/vm/zone_text_buffer.h:1: // Copyright (c) 2012, the Dart project
authors.  Please see the AUTHORS file
On 2017/02/09 20:37:48, zra wrote:
> 2017

Fixed in https://codereview.chromium.org/2686813006

Powered by Google App Engine
This is Rietveld 408576698