Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2686813006: Reapply "Use CodeSourceMap for stack traces (still JIT only)." (Closed)

Created:
3 years, 10 months ago by rmacnak
Modified:
3 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Use CodeSourceMap for stack traces (still JIT only)." - Fix missing null termination in initialization of ZoneTextBuffer. - Merge with John's async stack trace changes. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/b15b98bcc33dc5303fb4c0dff8441bb5294e4ab8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -206 lines) Patch
M runtime/tests/vm/dart/inline_stack_frame_test.dart View 3 chunks +24 lines, -15 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 5 chunks +12 lines, -6 lines 0 comments Download
M runtime/vm/code_descriptors.h View 4 chunks +56 lines, -22 lines 0 comments Download
M runtime/vm/code_descriptors.cc View 5 chunks +106 lines, -31 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +26 lines, -20 lines 0 comments Download
M runtime/vm/disassembler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.h View 2 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 5 chunks +20 lines, -11 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 2 chunks +11 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 7 chunks +43 lines, -75 lines 0 comments Download
M runtime/vm/profiler_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A runtime/vm/zone_text_buffer.h View 1 chunk +38 lines, -0 lines 0 comments Download
A runtime/vm/zone_text_buffer.cc View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 10 months ago (2017-02-10 01:45:11 UTC) #2
Florian Schneider
Lgtm
3 years, 10 months ago (2017-02-10 01:46:07 UTC) #3
rmacnak
3 years, 10 months ago (2017-02-10 02:03:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b15b98bcc33dc5303fb4c0dff8441bb5294e4ab8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698