Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2689553002: [ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:unit_tests to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2689553002 Cr-Commit-Position: refs/heads/master@{#449596} Committed: https://chromium.googlesource.com/chromium/src/+/91629e936f9d1b3c4ee70e35d9762c4e4d02a249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -22 lines) Patch
M ios/chrome/browser/ui/tab_switcher/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_model_snapshot_unittest.mm View 3 chunks +10 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_model_unittest.mm View 6 chunks +17 lines, -14 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_utils_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
lody
[ObjC ARC] Converts ios/chrome/common:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None
3 years, 10 months ago (2017-02-09 17:05:13 UTC) #3
lody
Please review, thanks
3 years, 10 months ago (2017-02-10 09:08:58 UTC) #11
lody
Please review, thanks
3 years, 10 months ago (2017-02-10 09:08:58 UTC) #12
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-10 10:56:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689553002/1
3 years, 10 months ago (2017-02-10 12:02:38 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 12:11:56 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/91629e936f9d1b3c4ee70e35d976...

Powered by Google App Engine
This is Rietveld 408576698