Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2689533002: [ObjC ARC] Converts ios/chrome/browser/ui/activity_services:unit_tests to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
Reviewers:
stkhapugin, sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/activity_services:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2689533002 Cr-Commit-Position: refs/heads/master@{#450357} Committed: https://chromium.googlesource.com/chromium/src/+/4cdadb3a5457e6e59bb13be30c2584e81feac9b4

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -86 lines) Patch
M ios/chrome/browser/ui/activity_services/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm View 1 17 chunks +84 lines, -83 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/chrome_activity_item_thumbnail_generator_unittest.mm View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
lody
Please review, thank you
3 years, 10 months ago (2017-02-09 15:53:43 UTC) #4
sdefresne
https://codereview.chromium.org/2689533002/diff/1/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm File ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm (right): https://codereview.chromium.org/2689533002/diff/1/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm#newcode291 ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm:291: result = [NSDictionary dictionary]; nit: result = @{};
3 years, 10 months ago (2017-02-09 16:05:05 UTC) #5
lody
https://codereview.chromium.org/2689533002/diff/1/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm File ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm (right): https://codereview.chromium.org/2689533002/diff/1/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm#newcode291 ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm:291: result = [NSDictionary dictionary]; On 2017/02/09 16:05:05, sdefresne wrote: ...
3 years, 10 months ago (2017-02-09 16:18:20 UTC) #8
lody
ping!
3 years, 10 months ago (2017-02-13 15:09:07 UTC) #9
sdefresne
lgtm
3 years, 10 months ago (2017-02-13 15:38:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689533002/20001
3 years, 10 months ago (2017-02-14 14:24:49 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 15:26:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4cdadb3a5457e6e59bb13be30c25...

Powered by Google App Engine
This is Rietveld 408576698