Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: cc/ipc/struct_traits_unittest.cc

Issue 2689513003: Add field-initializing constructors to generated mojo structs. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/ipc/compositor_frame_metadata.typemap ('k') | mojo/common/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/ipc/struct_traits_unittest.cc
diff --git a/cc/ipc/struct_traits_unittest.cc b/cc/ipc/struct_traits_unittest.cc
index 2ac039498942aeaf2cb84594207d6f6c959c792b..8088ac9d6ad0ef679ec898e560923e4bf9d6c2b6 100644
--- a/cc/ipc/struct_traits_unittest.cc
+++ b/cc/ipc/struct_traits_unittest.cc
@@ -48,9 +48,9 @@ class StructTraitsTest : public testing::Test, public mojom::TraitsTestService {
}
void EchoCompositorFrameMetadata(
- const CompositorFrameMetadata& c,
+ CompositorFrameMetadata c,
const EchoCompositorFrameMetadataCallback& callback) override {
- callback.Run(c);
+ callback.Run(std::move(c));
}
void EchoCopyOutputRequest(
@@ -357,7 +357,7 @@ TEST_F(StructTraitsTest, CompositorFrameMetadata) {
mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
CompositorFrameMetadata output;
- proxy->EchoCompositorFrameMetadata(input, &output);
+ proxy->EchoCompositorFrameMetadata(std::move(input), &output);
EXPECT_EQ(device_scale_factor, output.device_scale_factor);
EXPECT_EQ(root_scroll_offset, output.root_scroll_offset);
EXPECT_EQ(page_scale_factor, output.page_scale_factor);
« no previous file with comments | « cc/ipc/compositor_frame_metadata.typemap ('k') | mojo/common/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698