mojo/common/values.typemap - Issue 2689513003: Add field-initializing constructors to generated mojo structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/common/values.typemap

Issue 2689513003: Add field-initializing constructors to generated mojo structs. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/common/values.typemap

diff --git a/mojo/common/values.typemap b/mojo/common/values.typemap

index 069c277940b2c8e083ee310c994b34d4558b5274..f1f3fc2772fb055951c0b28f4f4321eccd75506e 100644

--- a/mojo/common/values.typemap

+++ b/mojo/common/values.typemap

@@ -19,7 +19,7 @@ sources = [

type_mappings = [

"mojo.common.mojom.DictionaryValue=std::unique_ptr<base::DictionaryValue>[move_only,nullable_is_same_type]",

- "mojo.common.mojom.LegacyListValue=base::ListValue",

+ "mojo.common.mojom.LegacyListValue=base::ListValue[non_copyable_non_movable]",

"mojo.common.mojom.ListValue=std::unique_ptr<base::ListValue>[move_only,nullable_is_same_type]",

"mojo.common.mojom.Value=std::unique_ptr<base::Value>[move_only,nullable_is_same_type]",

]