[ObjC ARC] Converts ios/chrome/common:common to ARC.

[ObjC ARC] Converts ios/chrome/common:common to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2689513002
Cr-Commit-Position: refs/heads/master@{#449312}
Committed: https://chromium.googlesource.com/chromium/src/+/fa26a7bb6111ef60a98049434b73705ff1c5f2a5

[lody, 2017-02-09 14:03:13]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 14:03:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lody, 2017-02-09 14:11:18]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 14:11:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 15:13:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 15:13:14]

Dry run: This issue passed the CQ dry run.

[lody, 2017-02-09 16:26:31]

lod@chromium.org changed reviewers:
+ sdefresne@chromium.org, stkhapugin@chromium.org

[lody, 2017-02-09 16:26:31]

Please review this cl, thank you

[sdefresne, 2017-02-09 16:31:51]

lgtm

[lody, 2017-02-09 16:35:23]

The CQ bit was checked by lod@chromium.org

[commit-bot: I haz the power, 2017-02-09 16:35:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 16:41:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486658123586000,
"parent_rev": "83029845af8ac47ac5c8c0534a2a9fd673a59a3e", "commit_rev":
"fa26a7bb6111ef60a98049434b73705ff1c5f2a5"}

[commit-bot: I haz the power, 2017-02-09 16:41:46]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/common:common to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/common:common to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2689513002
Cr-Commit-Position: refs/heads/master@{#449312}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa26a7bb6111ef60a98049434b73...
==========

[commit-bot: I haz the power, 2017-02-09 16:41:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fa26a7bb6111ef60a98049434b73...

[pkl (ping after 24h if needed), 2017-02-09 16:46:36]

pkl@chromium.org changed reviewers:
+ pkl@chromium.org

[pkl (ping after 24h if needed), 2017-02-09 16:46:37]

Note that my comment is not specific to this CL, but general. If we think
git-cl-format should do better, we should file a bug report.

https://codereview.chromium.org/2689513002/diff/20001/ios/chrome/common/mater...
File ios/chrome/common/material_timing.mm (right):

https://codereview.chromium.org/2689513002/diff/20001/ios/chrome/common/mater...
ios/chrome/common/material_timing.mm:49: 0.13f:0.99f];
Is this what git-cl-format did? This looks less readable when the : is placed
after each parameter. I can't find any style guide recommendation on this.

[lody, 2017-02-09 16:51:50]

https://codereview.chromium.org/2689513002/diff/20001/ios/chrome/common/mater...
File ios/chrome/common/material_timing.mm (right):

https://codereview.chromium.org/2689513002/diff/20001/ios/chrome/common/mater...
ios/chrome/common/material_timing.mm:49: 0.13f:0.99f];
On 2017/02/09 16:46:37, pklpkl wrote:
> Is this what git-cl-format did? This looks less readable when the : is placed
> after each parameter. I can't find any style guide recommendation on this.

Yeah, I just tried to make sure and it is git cl format doing that. Totally
agree that this looks awful. I think it's confused by the lack of argument names
(so am I ;) ).

[pkl (ping after 24h if needed), 2017-02-09 19:39:40]

On 2017/02/09 16:51:50, lody wrote:
>
https://codereview.chromium.org/2689513002/diff/20001/ios/chrome/common/mater...
> File ios/chrome/common/material_timing.mm (right):
> 
>
https://codereview.chromium.org/2689513002/diff/20001/ios/chrome/common/mater...
> ios/chrome/common/material_timing.mm:49: 0.13f:0.99f];
> On 2017/02/09 16:46:37, pklpkl wrote:
> > Is this what git-cl-format did? This looks less readable when the : is
placed
> > after each parameter. I can't find any style guide recommendation on this.
> 
> Yeah, I just tried to make sure and it is git cl format doing that. Totally
> agree that this looks awful. I think it's confused by the lack of argument
names
> (so am I ;) ).

Filed http://crbug/690581