Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2689483003: Make cast_channel::Logger RefCountedThreadSafe (Closed)

Created:
3 years, 10 months ago by tzik
Modified:
3 years, 10 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make cast_channel::Logger RefCountedThreadSafe cast_channel::Logger has non-thread-safe ref count, and is accessed from both UI thread and IO thread. So the thread safe version of ref count seems better fit. Review-Url: https://codereview.chromium.org/2689483003 Cr-Commit-Position: refs/heads/master@{#449531} Committed: https://chromium.googlesource.com/chromium/src/+/5302bd84dbd94a66a6e5d6601a637cb236479d3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M extensions/browser/api/cast_channel/logger.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
tzik
PTAL
3 years, 10 months ago (2017-02-09 10:34:06 UTC) #7
Ken Rockot(use gerrit already)
LGTM but note that cast_channel has a more specific OWNERS file
3 years, 10 months ago (2017-02-09 17:19:36 UTC) #8
tzik
On 2017/02/09 17:19:36, Ken Rockot wrote: > LGTM but note that cast_channel has a more ...
3 years, 10 months ago (2017-02-09 21:11:44 UTC) #10
Wez
LGTM - good spot - thanks! +imcheng FYI
3 years, 10 months ago (2017-02-09 21:41:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689483003/1
3 years, 10 months ago (2017-02-10 02:33:59 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 02:40:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5302bd84dbd94a66a6e5d6601a63...

Powered by Google App Engine
This is Rietveld 408576698