CSP: Add test: Allow port upgrade without scheme upgrade and vice versa.

CSP: Add test: Allow port upgrade without scheme upgrade and vice versa.

This is a backport of a test in:
https://codereview.chromium.org/2612793002/

What is interesting in this test is that CSP allow port and scheme to be
upgraded in their secure version independently. The result is that one
of them can be upgraded without the other (http on port 443 or https on
port 80).

BUG=692499
Review-Url: https://codereview.chromium.org/2689363003
Cr-Commit-Position: refs/heads/master@{#450685}
Committed: https://chromium.googlesource.com/chromium/src/+/ba1205f748c335e037ad516e29cee9d23dffd21f

[arthursonzogni, 2017-02-14 14:52:53]

arthursonzogni@chromium.org changed reviewers:
+ mkwst@chromium.org

[arthursonzogni, 2017-02-14 14:52:53]

Hi Mike,

This is another backport of the test whose results looks strange. We get the
same result on the renderer-side.
Please take a look, thanks!

[Mike West, 2017-02-15 06:40:03]

LGTM if you file bugs. :)

https://codereview.chromium.org/2689363003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp (right):

https://codereview.chromium.org/2689363003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp:151:
EXPECT_TRUE(source.matches(KURL(base, "http://example.com:443/")));
Here too. :)

https://codereview.chromium.org/2689363003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp:153:
EXPECT_TRUE(source.matches(KURL(base, "https://example.com:80/")));
Also here.

https://codereview.chromium.org/2689363003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp:176:
EXPECT_TRUE(source.matches(KURL(base, "http://example.com:443")));
Please file a bug and turn this into a TODO.

[arthursonzogni, 2017-02-15 12:16:41]

Description was changed from

==========
CSP: Backport test - allow port upgrade without scheme upgrade.

This is a backport of a test in:
https://codereview.chromium.org/2612793002/

What is interesting in this test is that CSP allow port and scheme to be
upgraded in their secure version independently. The result is that one
of them can be upgraded without the other (http on port 443 or https on
port 80).

BUG=ToBeDefined.
==========

to

==========
CSP: Add test: Allow port upgrade without scheme upgrade and vice versa.

This is a backport of a test in:
https://codereview.chromium.org/2612793002/

What is interesting in this test is that CSP allow port and scheme to be
upgraded in their secure version independently. The result is that one
of them can be upgraded without the other (http on port 443 or https on
port 80).

BUG=692499
==========

[arthursonzogni, 2017-02-15 12:17:39]

The CQ bit was checked by arthursonzogni@chromium.org

[arthursonzogni, 2017-02-15 12:17:39]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2689363003/#ps20001
(title: "Add TODO and BUG id.")

[arthursonzogni, 2017-02-15 12:17:51]

Thanks!

https://codereview.chromium.org/2689363003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp (right):

https://codereview.chromium.org/2689363003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp:151:
EXPECT_TRUE(source.matches(KURL(base, "http://example.com:443/")));
On 2017/02/15 06:40:02, Mike West (sloooooow) wrote:
> Here too. :)

Done. BUG=692499

https://codereview.chromium.org/2689363003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp:153:
EXPECT_TRUE(source.matches(KURL(base, "https://example.com:80/")));
On 2017/02/15 06:40:02, Mike West (sloooooow) wrote:
> Also here.

Done. BUG=692499

https://codereview.chromium.org/2689363003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp:176:
EXPECT_TRUE(source.matches(KURL(base, "http://example.com:443")));
On 2017/02/15 06:40:02, Mike West (sloooooow) wrote:
> Please file a bug and turn this into a TODO.

Done. BUG=692499

[commit-bot: I haz the power, 2017-02-15 12:18:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 13:25:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487161059389530,
"parent_rev": "df05e7ac8ec9c43c03b8e066b3cf538c2c274cef", "commit_rev":
"ba1205f748c335e037ad516e29cee9d23dffd21f"}

[commit-bot: I haz the power, 2017-02-15 13:26:35]

Description was changed from

==========
CSP: Add test: Allow port upgrade without scheme upgrade and vice versa.

This is a backport of a test in:
https://codereview.chromium.org/2612793002/

What is interesting in this test is that CSP allow port and scheme to be
upgraded in their secure version independently. The result is that one
of them can be upgraded without the other (http on port 443 or https on
port 80).

BUG=692499
==========

to

==========
CSP: Add test: Allow port upgrade without scheme upgrade and vice versa.

This is a backport of a test in:
https://codereview.chromium.org/2612793002/

What is interesting in this test is that CSP allow port and scheme to be
upgraded in their secure version independently. The result is that one
of them can be upgraded without the other (http on port 443 or https on
port 80).

BUG=692499

Review-Url: https://codereview.chromium.org/2689363003
Cr-Commit-Position: refs/heads/master@{#450685}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba1205f748c335e037ad516e29ce...
==========

[commit-bot: I haz the power, 2017-02-15 13:26:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba1205f748c335e037ad516e29ce...