Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2689323006: Read USB device configurations from index 0. (Closed)

Created:
3 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
juncai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Read USB device configurations from index 0. When building the new Windows USB backend I noticed that Windows rejected requests for the configuration descriptor at index 1. Further research indicates that while the bConfigurationValue inside a configuration descriptor starts at 1 the index sent in a GET_DESCRIPTOR request should start at 0. The reason this wasn't noticed is that most devices only have one configuration descriptor and simply don't care what index you ask for. BUG=None Review-Url: https://codereview.chromium.org/2689323006 Cr-Commit-Position: refs/heads/master@{#451082} Committed: https://chromium.googlesource.com/chromium/src/+/d6578223737c26a53f01c5e402c3511e83aa87a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M device/usb/usb_descriptors.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_descriptors_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Reilly Grant (use Gerrit)
PTAL
3 years, 10 months ago (2017-02-16 01:32:49 UTC) #3
juncai
LGTM.
3 years, 10 months ago (2017-02-16 19:09:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689323006/1
3 years, 10 months ago (2017-02-16 19:24:13 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 20:23:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6578223737c26a53f01c5e402c3...

Powered by Google App Engine
This is Rietveld 408576698