Added additional logging to flaky test "LoginGuestTest.CursorShown"

Added additional logging to flaky test "LoginGuestTest.CursorShown"

BUG=693106
TEST=interactive_ui_browsertests

Review-Url: https://codereview.chromium.org/2689283010
Cr-Commit-Position: refs/heads/master@{#451379}
Committed: https://chromium.googlesource.com/chromium/src/+/18e708a65aceef17a02b4aad341015be24606141

[bruthig, 2017-02-16 22:48:03]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 22:49:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2017-02-16 22:49:46]

bruthig@chromium.org changed reviewers:
+ sky@chromium.org

[bruthig, 2017-02-16 22:49:47]

sky@, can you PTAL?

[commit-bot: I haz the power, 2017-02-17 02:19:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:19:22]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-17 16:44:13]

https://codereview.chromium.org/2689283010/diff/1/ui/gfx/geometry/test/rect_t...
File ui/gfx/geometry/test/rect_test_util.cc (right):

https://codereview.chromium.org/2689283010/diff/1/ui/gfx/geometry/test/rect_t...
ui/gfx/geometry/test/rect_test_util.cc:13: return testing::AssertionSuccess()
Is it really typical to log information about the reason for success? I
definitely get logging the failure reason, but logging success seems excessive.

[bruthig, 2017-02-17 16:49:17]

https://codereview.chromium.org/2689283010/diff/1/ui/gfx/geometry/test/rect_t...
File ui/gfx/geometry/test/rect_test_util.cc (right):

https://codereview.chromium.org/2689283010/diff/1/ui/gfx/geometry/test/rect_t...
ui/gfx/geometry/test/rect_test_util.cc:13: return testing::AssertionSuccess()
On 2017/02/17 16:44:13, sky wrote:
> Is it really typical to log information about the reason for success? I
> definitely get logging the failure reason, but logging success seems
excessive.

The success logging will be used if it fails an (EXPECT|ASSERT)_FALSE().

[sky, 2017-02-17 20:41:26]

Got it, thanks. LGTM

[bruthig, 2017-02-17 20:43:48]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:44:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 21:06:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487364228020190, "parent_rev":
"15d052adb744d524228947248ab96c80b3bdf7ad", "commit_rev":
"18e708a65aceef17a02b4aad341015be24606141"}

[commit-bot: I haz the power, 2017-02-17 21:06:50]

Description was changed from

==========
Added additional logging to flaky test "LoginGuestTest.CursorShown"

BUG=693106
TEST=interactive_ui_browsertests
==========

to

==========
Added additional logging to flaky test "LoginGuestTest.CursorShown"

BUG=693106
TEST=interactive_ui_browsertests

Review-Url: https://codereview.chromium.org/2689283010
Cr-Commit-Position: refs/heads/master@{#451379}
Committed:
https://chromium.googlesource.com/chromium/src/+/18e708a65aceef17a02b4aad3410...
==========

[commit-bot: I haz the power, 2017-02-17 21:06:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18e708a65aceef17a02b4aad3410...