Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2689283010: Added additional logging to flaky test "LoginGuestTest.CursorShown" (Closed)

Created:
3 years, 10 months ago by bruthig
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, cc-bugs_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added additional logging to flaky test "LoginGuestTest.CursorShown" BUG=693106 TEST=interactive_ui_browsertests Review-Url: https://codereview.chromium.org/2689283010 Cr-Commit-Position: refs/heads/master@{#451379} Committed: https://chromium.googlesource.com/chromium/src/+/18e708a65aceef17a02b4aad341015be24606141

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
M chrome/browser/chromeos/login/login_browsertest.cc View 3 chunks +12 lines, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/gfx/geometry/test/rect_test_util.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ui/gfx/geometry/test/rect_test_util.cc View 1 chunk +23 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (8 generated)
bruthig
sky@, can you PTAL?
3 years, 10 months ago (2017-02-16 22:49:47 UTC) #4
sky
https://codereview.chromium.org/2689283010/diff/1/ui/gfx/geometry/test/rect_test_util.cc File ui/gfx/geometry/test/rect_test_util.cc (right): https://codereview.chromium.org/2689283010/diff/1/ui/gfx/geometry/test/rect_test_util.cc#newcode13 ui/gfx/geometry/test/rect_test_util.cc:13: return testing::AssertionSuccess() Is it really typical to log information ...
3 years, 10 months ago (2017-02-17 16:44:13 UTC) #7
bruthig
https://codereview.chromium.org/2689283010/diff/1/ui/gfx/geometry/test/rect_test_util.cc File ui/gfx/geometry/test/rect_test_util.cc (right): https://codereview.chromium.org/2689283010/diff/1/ui/gfx/geometry/test/rect_test_util.cc#newcode13 ui/gfx/geometry/test/rect_test_util.cc:13: return testing::AssertionSuccess() On 2017/02/17 16:44:13, sky wrote: > Is ...
3 years, 10 months ago (2017-02-17 16:49:17 UTC) #8
sky
Got it, thanks. LGTM
3 years, 10 months ago (2017-02-17 20:41:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689283010/1
3 years, 10 months ago (2017-02-17 20:44:29 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 21:06:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18e708a65aceef17a02b4aad3410...

Powered by Google App Engine
This is Rietveld 408576698