Chromium Code Reviews

Issue 2689283007: Update libwebp to 0.6.0 (Closed)

Created:
3 years, 10 months ago by scroggo_chromium
Modified:
3 years, 10 months ago
Reviewers:
msarett, scroggo, msarett1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update libwebp to 0.6.0 Corresponds with Android change https://android-review.googlesource.com/#/c/326439/ "this version includes encoder and performance improvements" Update build file * Many files have been renamed from src/<subdir>/<name>.c to src/<subdir>/<name>_<subdir>.c * Build new files (*_msa.c, *_neon.c, predictor_enc.c) This should fix issue 5876, which was caused by a compiler bug. With the added NEON implementation, we will no longer trigger the bug. BUG=skia:5876 CQ_INCLUDE_TRYBOTS=skia.primary:Build-Mac-Clang-arm-Debug-iOS Review-Url: https://codereview.chromium.org/2689283007 Committed: https://skia.googlesource.com/skia/+/1e532d3ad331e8e79ff48b0da475080fc591ce7e

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+52 lines, -43 lines)
M DEPS View 1 chunk +1 line, -1 line 0 comments
M third_party/libwebp/BUILD.gn View 2 chunks +51 lines, -42 lines 0 comments

Messages

Total messages: 16 (10 generated)
scroggo
3 years, 10 months ago (2017-02-15 22:10:09 UTC) #2
msarett1
lgtm
3 years, 10 months ago (2017-02-15 22:11:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689283007/1
3 years, 10 months ago (2017-02-16 13:48:48 UTC) #11
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
3 years, 10 months ago (2017-02-16 13:48:50 UTC) #12
scroggo
lgtm
3 years, 10 months ago (2017-02-16 13:57:03 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 13:57:46 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1e532d3ad331e8e79ff48b0da475080fc591ce7e

Powered by Google App Engine