Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2689283003: chromeos: removes underlay surface offset (Closed)

Created:
3 years, 10 months ago by sky
Modified:
3 years, 10 months ago
Reviewers:
Tom Sepez, mfomitchev
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: removes underlay surface offset It's no longer used. BUG=670840 TEST=none R=mfomitchev@chromium.org, tsepez@chromium.org Review-Url: https://codereview.chromium.org/2689283003 Cr-Commit-Position: refs/heads/master@{#450442} Committed: https://chromium.googlesource.com/chromium/src/+/38dca0b349f34191c1a533d103b270d3571ce18d

Patch Set 1 #

Total comments: 2

Patch Set 2 : log error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -43 lines) Patch
M ash/mus/non_client_frame_controller.cc View 1 chunk +1 line, -4 lines 0 comments Download
M services/ui/public/interfaces/window_manager.mojom View 1 chunk +4 lines, -8 lines 0 comments Download
M services/ui/ws/window_tree.h View 1 chunk +1 line, -5 lines 0 comments Download
M services/ui/ws/window_tree.cc View 1 1 chunk +9 lines, -8 lines 0 comments Download
M ui/aura/mus/window_manager_delegate.h View 2 chunks +2 lines, -5 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 1 chunk +1 line, -4 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
sky
tsepez: mojom mfomitchev: the rest
3 years, 10 months ago (2017-02-13 22:48:06 UTC) #1
Tom Sepez
LGTM on reducing mojom functionality.
3 years, 10 months ago (2017-02-13 23:04:18 UTC) #4
mfomitchev
LGTM with one suggestion https://codereview.chromium.org/2689283003/diff/1/services/ui/ws/window_tree.cc File services/ui/ws/window_tree.cc (right): https://codereview.chromium.org/2689283003/diff/1/services/ui/ws/window_tree.cc#newcode1944 services/ui/ws/window_tree.cc:1944: if (!window || window->id().client_id != ...
3 years, 10 months ago (2017-02-14 18:27:12 UTC) #7
sky
https://codereview.chromium.org/2689283003/diff/1/services/ui/ws/window_tree.cc File services/ui/ws/window_tree.cc (right): https://codereview.chromium.org/2689283003/diff/1/services/ui/ws/window_tree.cc#newcode1944 services/ui/ws/window_tree.cc:1944: if (!window || window->id().client_id != id_) On 2017/02/14 18:27:12, ...
3 years, 10 months ago (2017-02-14 18:32:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689283003/20001
3 years, 10 months ago (2017-02-14 18:33:57 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 20:20:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/38dca0b349f34191c1a533d103b2...

Powered by Google App Engine
This is Rietveld 408576698