Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2689243002: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. (Closed)

Created:
3 years, 10 months ago by zakerinasab
Modified:
3 years, 10 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. This change replaces js-test.js assertions with testharness.js assertions. The expectation files are removed as they are not needed anymore. To simplify review and landing, each change corrects at most 10 tests. BUG=639732 Review-Url: https://codereview.chromium.org/2689243002 Cr-Commit-Position: refs/heads/master@{#451071} Committed: https://chromium.googlesource.com/chromium/src/+/601dc9f2edb0f9410d3c79a459a56ef38ba68cf1

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+737 lines, -1490 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/canvas-path-context-clip.html View 1 chunk +72 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-path-context-clip-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-path-context-fill.html View 1 chunk +70 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-path-context-fill-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-path-context-stroke.html View 1 chunk +46 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-path-context-stroke-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-path-object.html View 1 chunk +19 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-path-object-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-path-with-inf-nan-dimensions.html View 1 chunk +47 lines, -96 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-path-with-inf-nan-dimensions-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-behaviour.html View 1 1 chunk +74 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-behaviour.js View 1 chunk +0 lines, -135 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-behaviour-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-modify.html View 1 chunk +40 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-modify.js View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-modify-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-set-transform.html View 1 chunk +45 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-set-transform-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-transform.html View 1 chunk +41 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-transform.js View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-transform-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-putImageData.html View 1 chunk +283 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-putImageData.js View 1 chunk +0 lines, -237 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-putImageData-expected.txt View 1 chunk +0 lines, -172 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-path-context-clip.js View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-path-context-fill.js View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-path-context-stroke.js View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-path-object.js View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-pattern-set-transform.js View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-clip-expected.txt View 1 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-fill-expected.txt View 1 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-stroke-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
Justin Novosad
lgtm with nit https://codereview.chromium.org/2689243002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-behaviour.html File third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-behaviour.html (right): https://codereview.chromium.org/2689243002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-behaviour.html#newcode30 third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-behaviour.html:30: var pattern = context.createPattern(green1x1, null); inconsistent ...
3 years, 10 months ago (2017-02-16 15:50:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689243002/20001
3 years, 10 months ago (2017-02-16 18:42:13 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 20:06:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/601dc9f2edb0f9410d3c79a459a5...

Powered by Google App Engine
This is Rietveld 408576698