third_party/WebKit/Source/core/editing/InputMethodController.h - Issue 2689233006: Fix bug on Android causing composition underlines to appear in the wrong place

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 2689233006: Fix bug on Android causing composition underlines to appear in the wrong place (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/InputMethodController.h

diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.h b/third_party/WebKit/Source/core/editing/InputMethodController.h

index 09a21529773d8c6ac307eb452d124485548713bf..52be4e2e5ab2e0bbebc83b9b3cc7d81ad710f622 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodController.h

+++ b/third_party/WebKit/Source/core/editing/InputMethodController.h

@@ -134,7 +134,7 @@ class CORE_EXPORT InputMethodController final

FrameSelection::SetSelectionOptions = FrameSelection::CloseTyping);

void addCompositionUnderlines(const Vector<CompositionUnderline>& underlines,

- ContainerNode* rootEditableElement,

+ ContainerNode* baseElement,

unsigned offset);

bool insertText(const String&);