Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Side by Side Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 2689233006: Fix bug on Android causing composition underlines to appear in the wrong place (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 void selectComposition() const; 127 void selectComposition() const;
128 128
129 EphemeralRange ephemeralRangeForOffsets(const PlainTextRange&) const; 129 EphemeralRange ephemeralRangeForOffsets(const PlainTextRange&) const;
130 130
131 // Returns true if selection offsets were successfully set. 131 // Returns true if selection offsets were successfully set.
132 bool setSelectionOffsets( 132 bool setSelectionOffsets(
133 const PlainTextRange&, 133 const PlainTextRange&,
134 FrameSelection::SetSelectionOptions = FrameSelection::CloseTyping); 134 FrameSelection::SetSelectionOptions = FrameSelection::CloseTyping);
135 135
136 void addCompositionUnderlines(const Vector<CompositionUnderline>& underlines, 136 void addCompositionUnderlines(const Vector<CompositionUnderline>& underlines,
137 ContainerNode* rootEditableElement, 137 ContainerNode* baseElement,
138 unsigned offset); 138 unsigned offset);
139 139
140 bool insertText(const String&); 140 bool insertText(const String&);
141 bool insertTextAndMoveCaret(const String&, 141 bool insertTextAndMoveCaret(const String&,
142 int relativeCaretPosition, 142 int relativeCaretPosition,
143 const Vector<CompositionUnderline>& underlines); 143 const Vector<CompositionUnderline>& underlines);
144 144
145 // Inserts the given text string in the place of the existing composition. 145 // Inserts the given text string in the place of the existing composition.
146 // Returns true if did replace. 146 // Returns true if did replace.
147 bool replaceComposition(const String& text); 147 bool replaceComposition(const String& text);
(...skipping 13 matching lines...) Expand all
161 int textInputFlags() const; 161 int textInputFlags() const;
162 WebTextInputMode inputModeOfFocusedElement() const; 162 WebTextInputMode inputModeOfFocusedElement() const;
163 163
164 // Implements |SynchronousMutationObserver|. 164 // Implements |SynchronousMutationObserver|.
165 void contextDestroyed(Document*) final; 165 void contextDestroyed(Document*) final;
166 }; 166 };
167 167
168 } // namespace blink 168 } // namespace blink
169 169
170 #endif // InputMethodController_h 170 #endif // InputMethodController_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698