chrome/install_static/BUILD.gn - Issue 2689233005: Move brand- and mode-specific app icon resource id into InstallConstants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/install_static/BUILD.gn

Issue 2689233005: Move brand- and mode-specific app icon resource id into InstallConstants. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/install_static/BUILD.gn

diff --git a/chrome/install_static/BUILD.gn b/chrome/install_static/BUILD.gn

index 4f57be6079c791c94035bf37494cf06103de6feb..adac9489f51994461db377dbe6bd3ec8258437a8 100644

--- a/chrome/install_static/BUILD.gn

+++ b/chrome/install_static/BUILD.gn

@@ -19,6 +19,7 @@ static_library("install_static_util") {

]

sources = [

+ "../app/chrome_dll_resource.h",

gab 2017/02/15 14:30:53 This is weird? i.e. as a DEPS it makes sense but a

grt (UTC plus 2) 2017/02/15 15:11:42 Maybe this isn't the right thing/needed. I'll chec

"install_constants.h",

"install_details.cc",

"install_details.h",

« no previous file with comments | « chrome/browser/win/app_icon.cc ('k') | chrome/install_static/DEPS » ('j') | no next file with comments »