Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: chrome/install_static/BUILD.gn

Issue 2689233005: Move brand- and mode-specific app icon resource id into InstallConstants. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/win/app_icon.cc ('k') | chrome/install_static/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 7
8 assert(is_win) 8 assert(is_win)
9 9
10 # This file only contains utility functions which must only depend on kernel32. 10 # This file only contains utility functions which must only depend on kernel32.
11 # Please don't add dependencies on other system libraries. 11 # Please don't add dependencies on other system libraries.
12 static_library("install_static_util") { 12 static_library("install_static_util") {
13 deps = [ 13 deps = [
14 "//components/version_info:generate_version_info", 14 "//components/version_info:generate_version_info",
15 ] 15 ]
16 16
17 public_deps = [ 17 public_deps = [
18 "//chrome_elf:nt_registry", 18 "//chrome_elf:nt_registry",
19 ] 19 ]
20 20
21 sources = [ 21 sources = [
22 "../app/chrome_dll_resource.h",
gab 2017/02/15 14:30:53 This is weird? i.e. as a DEPS it makes sense but a
grt (UTC plus 2) 2017/02/15 15:11:42 Maybe this isn't the right thing/needed. I'll chec
22 "install_constants.h", 23 "install_constants.h",
23 "install_details.cc", 24 "install_details.cc",
24 "install_details.h", 25 "install_details.h",
25 "install_modes.cc", 26 "install_modes.cc",
26 "install_modes.h", 27 "install_modes.h",
27 "install_util.cc", 28 "install_util.cc",
28 "install_util.h", 29 "install_util.h",
29 "policy_path_parser.cc", 30 "policy_path_parser.cc",
30 "policy_path_parser.h", 31 "policy_path_parser.h",
31 "product_install_details.cc", 32 "product_install_details.cc",
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 deps = [ 90 deps = [
90 "//base", 91 "//base",
91 "//base/test:run_all_unittests", 92 "//base/test:run_all_unittests",
92 "//base/test:test_support", 93 "//base/test:test_support",
93 "//chrome/install_static:install_static_util", 94 "//chrome/install_static:install_static_util",
94 "//chrome/install_static/test:test_support", 95 "//chrome/install_static/test:test_support",
95 "//testing/gmock", 96 "//testing/gmock",
96 "//testing/gtest", 97 "//testing/gtest",
97 ] 98 ]
98 } 99 }
OLDNEW
« no previous file with comments | « chrome/browser/win/app_icon.cc ('k') | chrome/install_static/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698