Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2689233004: Enable blink_perf.event on Windows (Closed)

Created:
3 years, 10 months ago by hayato
Modified:
3 years, 10 months ago
Reviewers:
Zhen Wang
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable blink_perf.event on Windows As far as I can confirm on perf trybot, the issue no longer happens. Let's enable blink_perf.event. https://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/7149 BUG=588819 Review-Url: https://codereview.chromium.org/2689233004 Cr-Commit-Position: refs/heads/master@{#452770} Committed: https://chromium.googlesource.com/chromium/src/+/7fc83944d69fe093a586a55bf4591f47b023f548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/perf/benchmarks/blink_perf.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
hayato
PTAL. Is it safe to land this CL if perf try does not complain?
3 years, 10 months ago (2017-02-22 04:34:23 UTC) #7
Zhen Wang
lgtm
3 years, 10 months ago (2017-02-22 04:44:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689233004/1
3 years, 10 months ago (2017-02-22 05:09:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/394904)
3 years, 10 months ago (2017-02-22 09:27:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689233004/1
3 years, 10 months ago (2017-02-24 04:24:02 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 06:09:31 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7fc83944d69fe093a586a55bf459...

Powered by Google App Engine
This is Rietveld 408576698