Defer NetworkConfigurationHandler::CreateShillConfiguration callback

Defer NetworkConfigurationHandler::CreateShillConfiguration callback

Currently the code calls the NetworkConfigurationHandler
::CreateShillConfiguration callback immediately, which is only
valid if Shill updates Chrome with the new network configuration
in the same frame as the configuration was applied. At some point
the Shill behavior Chrome, breaking the (fragile) Chrome network
cofiguration layer. This CL defers the configuration success
callback until the NetworkStateHandler has been updated with
the new configuration (allowing a subsequent connection attempt
to succeed).

This CL also replaces SupportsWeakPtr with the more reliable WeakPtrFactory (apologies for the churn).

BUG=662571
Review-Url: https://codereview.chromium.org/2679423008
Cr-Commit-Position: refs/heads/master@{#449787}
(cherry picked from commit 4be001fc71af06d07cb05c30e4b0665efadefed5)

Review-Url: https://codereview.chromium.org/2689223002 .
Cr-Commit-Position: refs/branch-heads/2987@{#479}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/dc15db5aaa57bb3f35137c1773db691af6a1414a

[stevenjb, 2017-02-13 18:50:09]

Description was changed from

==========
Defer NetworkConfigurationHandler::CreateShillConfiguration callback

Currently the code calls the NetworkConfigurationHandler
::CreateShillConfiguration callback immediately, which is only
valid if Shill updates Chrome with the new network configuration
in the same frame as the configuration was applied. At some point
the Shill behavior Chrome, breaking the (fragile) Chrome network
cofiguration layer. This CL defers the configuration success
callback until the NetworkStateHandler has been updated with
the new configuration (allowing a subsequent connection attempt
to succeed).

This CL also replaces SupportsWeakPtr with the more reliable WeakPtrFactory
(apologies for the churn).

BUG=662571

Review-Url: https://codereview.chromium.org/2679423008
Cr-Commit-Position: refs/heads/master@{#449787}
(cherry picked from commit 4be001fc71af06d07cb05c30e4b0665efadefed5)
==========

to

==========
Defer NetworkConfigurationHandler::CreateShillConfiguration callback

Currently the code calls the NetworkConfigurationHandler
::CreateShillConfiguration callback immediately, which is only
valid if Shill updates Chrome with the new network configuration
in the same frame as the configuration was applied. At some point
the Shill behavior Chrome, breaking the (fragile) Chrome network
cofiguration layer. This CL defers the configuration success
callback until the NetworkStateHandler has been updated with
the new configuration (allowing a subsequent connection attempt
to succeed).

This CL also replaces SupportsWeakPtr with the more reliable WeakPtrFactory
(apologies for the churn).

BUG=662571

Review-Url: https://codereview.chromium.org/2679423008
Cr-Commit-Position: refs/heads/master@{#449787}
(cherry picked from commit 4be001fc71af06d07cb05c30e4b0665efadefed5)

Review-Url: https://codereview.chromium.org/2689223002 .
Cr-Commit-Position: refs/branch-heads/2987@{#479}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc15db5aaa57bb3f35137c1773db...
==========

[stevenjb, 2017-02-13 18:50:11]

Committed patchset #1 (id:1) manually as
dc15db5aaa57bb3f35137c1773db691af6a1414a.